xalan-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Zongaro (JIRA)" <xalan-...@xml.apache.org>
Subject [jira] Commented: (XALANJ-2113) Exceptions created but not thrown
Date Mon, 08 Aug 2005 13:32:36 GMT
    [ http://issues.apache.org/jira/browse/XALANJ-2113?page=comments#action_12317988 ] 

Henry Zongaro commented on XALANJ-2113:

John, lines 962-964 of org.apache.xalan.xsltc.trax.TransformerFactoryImpl and lines 443-445
of org.apache.xalan.xsltc.trax.SmartTransformerFactoryImpl read as follows:

                catch (TransformerException e2) {
                    new TransformerConfigurationException(e2);

The TransformerConfigurationException that's constructed in this catch block is never thrown;
instead, the original exception, e1, will be thrown.  That's what Dave Brosius originally
complained about.

This segment of code also has the same problem that you'll find in org.apache.xalan.processor.TransformerFactoryImpl:
 if the ErrorListener throws a TransformerConfigurationException - a subclass of TransformerException
- this catch block will wrap it inside a second TransformerConfigurationException.  There
should be two catch blocks, one that handles TransformerConfigurationException and one that
handles TransformerException.

> Exceptions created but not thrown
> ---------------------------------
>          Key: XALANJ-2113
>          URL: http://issues.apache.org/jira/browse/XALANJ-2113
>      Project: XalanJ2
>         Type: Bug
>   Components: transformation
>     Versions: CurrentCVS
>  Environment: win32 xp
>     Reporter: Dave Brosius
>     Assignee: John Gentilin
>     Priority: Minor
>  Attachments: TransFacImpl-patch.txt, XfmrFacImpl-JIRA2113-Patch.txt
> Three instances of TranformFactoryImpl's implement the method newXMLFilter.
> In each case these methods create an Exception but do not throw it. It would seem that
that was the intent of creating the exception.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org

View raw message