www-legal-discuss mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LEGAL-267) Questionable use of third party code in major code contribution
Date Sun, 31 Jul 2016 11:26:20 GMT

    [ https://issues.apache.org/jira/browse/LEGAL-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401104#comment-15401104

Benedikt Ritter commented on LEGAL-267:


thank you for all your suggestions. I'm currently thinking about what to do now. Here is what
I understand so far:

- license wise it is not a problem to integrate that code, if we add proper attribution by
adding a NOTICE.txt file.
- the changes to eh ASM file have to be documented somewhere
- it would be better to only depend on ASM code, for example via maven dependency of sharding

Furthermore my initial assessment of the contribution was wrong. It does not seem to be copy
pasted, as the contributor said:

Nearly all of the copy/paste code was modified.
Only parts of the switch-case-statement in the "applyStatement" method is from the ASM-codebase.
In retrospect I had to alter nearly every single line of the copied code. If I change the
switch-case to a if-else not a single line would be the same as in the ASM-codebase.

Majority of the code was added by me based on the ASM-documentation about stackmaptables (see:

[1]: http://asm.ow2.org/doc/developer-guide.html#controlflow

If this really is the case (I have to check back with the ASM code base), I think it would
be safe to add the file with ASF header and add a comment that it is inspired by the ASM project.

> Questionable use of third party code in major code contribution
> ---------------------------------------------------------------
>                 Key: LEGAL-267
>                 URL: https://issues.apache.org/jira/browse/LEGAL-267
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Benedikt Ritter
> Hello,
> the Apache Commons project has received a major code donation via GitHub [1]. It looks
like good parts of that contribution have been copied from the ASM framework which is licensed
under the terms of BSD 3-Clause License. Given the information of the Previously Asked Questions
page [3], I assume that we could theoretically include this contribution. 
> - Can you confirm, that we can accept this contribution from a legal PoV? 
> - What would be a polite way to bring this to Commons BCEL WRT to the ASM project? The
contributor seems to be unrelated to ASM and has just copied the parts from ASM. Should we
notify the ASM project ob this?
> - The discussion at GitHub already brought up the topic of adding a NOTICE file. This
seems to be missing in the PR. Is that all that needs to be done to include this contribution?
> Thank you!
> [1] https://github.com/apache/commons-bcel/pull/7
> [2] http://asm.ow2.org/
> [3] http://www.apache.org/legal/resolved.html#category-a

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org

View raw message