www-legal-discuss mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LEGAL-267) Questionable use of third party code in major code contribution
Date Fri, 29 Jul 2016 16:29:20 GMT

    [ https://issues.apache.org/jira/browse/LEGAL-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399619#comment-15399619

Alex Harui commented on LEGAL-267:

AIUI, the contributor can only contribute his modifications unless there is documented permission
from the owners of the other lines of code (which I have done in the past).  

My mental model is that each line of code has a "home", where "home" is the place folks should
submit changes like bug fixes and discuss those changes.  ASM is a home for a bunch of files.
 Depending on the nature of the modifications in the pull request, the "home" for this contribution
should either just be the modifications needed to make the ASM code work with BCEL, or else
the modifications are so significant that a new "home" for this entire set of code seems like
it should belong at BCEL.  In the latter case, it might make sense to at least have a discussion
with the ASM folks to see if there is some refactoring they would want to do so the code to
make ASM work with BCEL is more easily separated and thus the "home" for nearly every ASM
file remains at ASM.  Or give permission for the BCEL version of ASM to live at the ASF. 
Or maybe they'll create a home for the BCEL version of ASM at ASM.

Personally, I would want the integration to be more easily separated so ASM code can continue
to live at ASM and the modifications required could be separated out and live at BCEL.  That
way, updates to ASM code doesn't have to be replicated to the BCEL copies.  In some cases,
we've just checked a .patch file into our repos and the build downloads the 3rd party code
and applies a patch.  Fewer forks in the world are better, IMO.

> Questionable use of third party code in major code contribution
> ---------------------------------------------------------------
>                 Key: LEGAL-267
>                 URL: https://issues.apache.org/jira/browse/LEGAL-267
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Benedikt Ritter
> Hello,
> the Apache Commons project has received a major code donation via GitHub [1]. It looks
like good parts of that contribution have been copied from the ASM framework which is licensed
under the terms of BSD 3-Clause License. Given the information of the Previously Asked Questions
page [3], I assume that we could theoretically include this contribution. 
> - Can you confirm, that we can accept this contribution from a legal PoV? 
> - What would be a polite way to bring this to Commons BCEL WRT to the ASM project? The
contributor seems to be unrelated to ASM and has just copied the parts from ASM. Should we
notify the ASM project ob this?
> - The discussion at GitHub already brought up the topic of adding a NOTICE file. This
seems to be missing in the PR. Is that all that needs to be done to include this contribution?
> Thank you!
> [1] https://github.com/apache/commons-bcel/pull/7
> [2] http://asm.ow2.org/
> [3] http://www.apache.org/legal/resolved.html#category-a

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org

View raw message