www-legal-discuss mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ryenus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LEGAL-156) Can we accept pull requests from github ?
Date Tue, 24 Sep 2013 00:02:04 GMT

    [ https://issues.apache.org/jira/browse/LEGAL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775827#comment-13775827
] 

ryenus commented on LEGAL-156:
------------------------------

I wonder why the issue is still open? why nobody taking care of this?

Pull requests are usually sent from forks/clones of the original repository on github, thus
should inherit the same license. A pull request is basically saying, here is what I give,
I'm asking you to take it, but it's you who decide whether to take it or not, at your own
wish, of course, for the sake of goodness.

Also, pull requests are now the defacto OSS contribution 'protocol' with enough implications
at the copyright granting perspective. Even if github is treated as a 'thirdparty', this thirdparty
has become mainstream these days, and besides the patch itself, it provides much more contextual
information, that's a great benefit compared to sending patches via emails.

BTW, regarding extracting the patch for a pull request, for any pull request, 

e.g. {{https://github.com/apache/maven-plugins/pull/13}}, by attaching the {{.patch}} suffix,
you get the raw patch url:

{{https://github.com/apache/maven-plugins/pull/13.patch}}

Just my 2 cents.

                
> Can we accept pull requests from github ?
> -----------------------------------------
>
>                 Key: LEGAL-156
>                 URL: https://issues.apache.org/jira/browse/LEGAL-156
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Kristian Rosenvold
>
> In maven, we generally require that all external submissions have JIRA issues. With svn
we would normally have patches attached to the jira issue, which would link a submission to
the submitter.
> With pull requests coming in from github, we receive a "submission" that is tagged with
author name and email and an external reference to the diff (a link to the commit on github).
This pull request is sent to ASF mailing lists and would IMO serve as a record of submission.
Given that the author information in the commit seems valid, can we accept such a pull request
directly ? (to this moment we still require that authors add patches to jira as well)
> (It would look to me like the only thing missing is that we have the process picking
up the pull requests actually attach the diff to the mail too, but heck IANAL).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org


Mime
View raw message