Mailing-List: contact legal-discuss-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: legal-discuss@apache.org
Date: Wed, 16 Jan 2013 16:30:15 +0000 (UTC)
From: "Kristian Rosenvold (JIRA)" <jira@apache.org>
To: legal-discuss@apache.org
Message-ID: <JIRA.12627782.1358320533492.145845.1358353815029@arcas>
In-Reply-To: <JIRA.12627782.1358320533492@arcas>
References: <JIRA.12627782.1358320533492@arcas>
Subject: [jira] [Commented] (LEGAL-156) Can we accept pull requests from
 github ?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LEGAL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555177#comment-13555177 ] 

Kristian Rosenvold commented on LEGAL-156:
------------------------------------------

@Daniel given that we actually parse the pull request email from github, actually fetching the diff in question from github and attaching it to the same email should be a trivial 5 line shell script. Would that do the trick ?
                
> Can we accept pull requests from github ?
> -----------------------------------------
>
>                 Key: LEGAL-156
>                 URL: https://issues.apache.org/jira/browse/LEGAL-156
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Kristian Rosenvold
>
> In maven, we generally require that all external submissions have JIRA issues. With svn we would normally have patches attached to the jira issue, which would link a submission to the submitter.
> With pull requests coming in from github, we receive a "submission" that is tagged with author name and email and an external reference to the diff (a link to the commit on github). This pull request is sent to ASF mailing lists and would IMO serve as a record of submission. Given that the author information in the commit seems valid, can we accept such a pull request directly ? (to this moment we still require that authors add patches to jira as well)
> (It would look to me like the only thing missing is that we have the process picking up the pull requests actually attach the diff to the mail too, but heck IANAL).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org