www-legal-discuss mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marvin Humphrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LEGAL-156) Can we accept pull requests from github ?
Date Wed, 16 Jan 2013 13:58:12 GMT

    [ https://issues.apache.org/jira/browse/LEGAL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555035#comment-13555035
] 

Marvin Humphrey commented on LEGAL-156:
---------------------------------------

> (It would look to me like the only thing missing is that we have the process
> picking up the pull requests actually attach the diff to the mail too, but
> heck IANAL). 

While the dev list notification emails for pull requests do not include full
diffs, they deliberately include the SHA checksums for each commit.  That
ought to be good enough as a record of what was contributed.

With regards to documenting the intent of the contributor, only a pull request
against one of the official mirrors at github.com/apache/* will trigger a dev
list email notification AFAIK.  If you have one of those notifications in your
email archives, that ought to suffice.

                
> Can we accept pull requests from github ?
> -----------------------------------------
>
>                 Key: LEGAL-156
>                 URL: https://issues.apache.org/jira/browse/LEGAL-156
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Kristian Rosenvold
>
> In maven, we generally require that all external submissions have JIRA issues. With svn
we would normally have patches attached to the jira issue, which would link a submission to
the submitter.
> With pull requests coming in from github, we receive a "submission" that is tagged with
author name and email and an external reference to the diff (a link to the commit on github).
This pull request is sent to ASF mailing lists and would IMO serve as a record of submission.
Given that the author information in the commit seems valid, can we accept such a pull request
directly ? (to this moment we still require that authors add patches to jira as well)
> (It would look to me like the only thing missing is that we have the process picking
up the pull requests actually attach the diff to the mail too, but heck IANAL).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org


Mime
View raw message