www-infrastructure-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-11555) mlreq.cgi & queuerun.py need to be consistent
Date Tue, 29 Mar 2016 09:13:25 GMT

    [ https://issues.apache.org/jira/browse/INFRA-11555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215716#comment-15215716

Sebb commented on INFRA-11555:

The patch looks OK, though I have since noticed that the MLID_PAT offers a stricter RE:

MLID_PAT = '^[a-z0-9]+(-[a-z0-9]+)?$'

Or even my proposed:

# Only allow empire-db to contain '-'
PROJ_PAT = '^(empire-db|[a-z][a-z0-9]+)$'

The patch is a good improvement as it allows empire-db lists now, which were previously rejected.

As to maintaining sync between the two scripts, a very simple solution for now would be add
comments to both reminding maintainers to keep them in step.

> mlreq.cgi & queuerun.py need to be consistent
> ---------------------------------------------
>                 Key: INFRA-11555
>                 URL: https://issues.apache.org/jira/browse/INFRA-11555
>             Project: Infrastructure
>          Issue Type: Task
>          Components: Mailing Lists
>            Reporter: Sebb
>            Priority: Minor
> The mlreq.cgi [1] app creates json input files which are processed by the queuerun.py
[2] script.
> Both perform input validation (and need to do so).
> This validation needs to be consistent, otherwise invalid requests can be created. Or
valid requests may be impossible to create via the CGI interface.
> Unfortunately the scripts are written in different languages so it's not possible to
share code. However it should be possible to use the same REs for basic validation, e.g. by
storing them in a shared JSON file (or by manual synch.).
> [1] https://svn.apache.org/repos/infra/infrastructure/trunk/projects/infra/www/officers/mlreq.cgi
> [2] https://svn.apache.org/repos/infra/infrastructure/trunk/mlreq/queuerun.py

This message was sent by Atlassian JIRA

View raw message