www-infrastructure-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (INFRA-2788) shorten.pl has incorrect $dbfile definition
Date Fri, 11 Jun 2010 15:39:13 GMT

     [ https://issues.apache.org/jira/browse/INFRA-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Sebb reopened INFRA-2788:


Another problem is the use of the DB_CREATE flag.

Should the database ever disappear, a new one will silently be created.
Which would allow duplicate keys to be created. Not good.

Seems to me it would be a lot safer to require that the database exists and fail otherwise.

> shorten.pl has incorrect $dbfile definition
> -------------------------------------------
>                 Key: INFRA-2788
>                 URL: https://issues.apache.org/jira/browse/INFRA-2788
>             Project: Infrastructure
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>         Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/shorten/shorten.pl
>            Reporter: Sebb
>            Priority: Minor
> I think the line
> $dbfile = '../db/store.dbm';
> should really be
> $dbfile = 'store.dbm';
> because the file is relative to the -Home flag, not the current working directory.
> The ../db obviously works, but serves no purpose.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message