www-infrastructure-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mridulm <...@git.apache.org>
Subject [GitHub] incubator-spark pull request: [SPARK-1100] prevent Spark from over...
Date Tue, 25 Feb 2014 06:20:51 GMT
Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/626#discussion_r10025532
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala ---
    @@ -603,8 +600,12 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD[(K, V)])
         val job = new NewAPIHadoopJob(conf)
         job.setOutputKeyClass(keyClass)
         job.setOutputValueClass(valueClass)
    +
         val wrappedConf = new SerializableWritable(job.getConfiguration)
         NewFileOutputFormat.setOutputPath(job, new Path(path))
    +    val jobFormat = outputFormatClass.newInstance
    +    jobFormat.checkOutputSpecs(new JobContext(wrappedConf.value, job.getJobID))
    +
    --- End diff --
    
    iirc this will fail even if there is an empty directory - is that the intention now ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message