Mailing-List: contact infrastructure-dev-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: infrastructure-dev@apache.org
Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.212.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1338987421.9404.YahooMailNeo@web160902.mail.bf1.yahoo.com>
References: <20120605175350.20B8DFFC3@tyr.zones.apache.org>
 <CABD8fLWJtumTw+0qvFOpenYg_xHaSTQuHUwDdEDphqrxQ3bF3g@mail.gmail.com>
 <1338922313.17426.YahooMailNeo@web160904.mail.bf1.yahoo.com>
 <CAOFYJNarYiGVm35ibg63gp19=4onD2s5PctWgBMKr4T=dYv_zg@mail.gmail.com>
 <1338987421.9404.YahooMailNeo@web160902.mail.bf1.yahoo.com>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Wed, 6 Jun 2012 15:45:31 +0200
Message-ID: 
 <CAOFYJNaLnMR_xVMAdzEzYn3X8b3-7E5B0LLXCS-0uMjYySAyXQ@mail.gmail.com>
Subject: Re: [1/2] git commit: f92a685 -
To: infrastructure-dev@apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Jun 6, 2012 at 2:57 PM, Joe Schaefer <joe_schaefer@yahoo.com> wrote=
:
> Sounds interesting Jukka- especially if we could keep it well
> correlated with the data in our "push logs".=A0 Do share more
> details.

Yep, basically the idea is that each entry in the push log (i.e.
branch B advanced from revision X to revision Y) results in a push
notification message.

For example, your push updated the master branch from revision
bee695d44c to f92a6853be. That update covers two commits (one normal
and one merge, see "git log bee695d44c..f92a6853be") and changes just
a single line (see "git diff bee695d44c..f92a6853be"). That
information, a log of the commits and the diff of all changes, should
be included in the push notification message.

See below for a relevant snippet from the script I have in place at
work. It has some Adobe-specific bits (HTML diffs, etc.), but I should
be able to adapt it for Apache with not much effort.

BR,

Jukka Zitting

----

$payload->{ref} =3D~ /^(refs\/heads\/)?(.*)/;
my $ref =3D $2;
my $ref_html =3D html($ref);

my $before =3D $payload->{before};
my $after =3D $payload->{after};
"$before..$after" =3D~ /^([a-f0-9]+\.\.[a-f0-9]+)$/ or die;
my $range =3D $1;

my $sbefore =3D substr($before, 0, 8);
my $safter =3D substr($after, 0, 8);
"$sbefore..$safter" =3D~ /^([a-f0-9]+\.\.[a-f0-9]+)$/ or die;
my $srange =3D  $1;

my $log_text  =3D `git log $range` or die;
my $log_html  =3D log_to_html($log_text);
my $stat_text =3D `git diff --stat $range -- . ` or die;
my $stat_html =3D stat_to_html($stat_text);
my $diff_text =3D `git diff $range -- . ` or die;
my $diff_html =3D diff_to_html($diff_text);

my ($subject_text, $is_rtc, $has_rtc, $has_bug) =3D
  review_commits(@{$payload->{commits}});
my $subject_html =3D html($subject_text);