www-infrastructure-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: subversion pull request: port to new style classes - http://stackoverflow.c...
Date Thu, 24 May 2012 10:48:41 GMT
(wearing both an infra hat and an svn hat...)

Filip Maj wrote on Thu, May 24, 2012 at 03:22:19 -0700:
> Without a doubt getting access to the project mirrors on GitHub is a
> must-have. Setting up different teams on GitHub is trivial. Could have a
> "committers" team, and any other team deemed necessary. We can then add
> permissions such as ability to administer the github project to these
> teams.
> 

Are you aware of Apache's requirements here?  Example: every commit must
generate an email notification.  Can you grant people access to github
in a manner that preserves this requirement?

> As for sending the patch, I don't see anything wrong with accepting a
> patch via GitHub. I fail to see the difference between accepting a patch
> via e-mail on dev lists vs. doing so via GitHub. In fact, I would say that
> accepting the patch on GitHub is *easier* than any other approved method
> in Apache so far (that I've experienced). You can comment on specific
> lines of code in a clearer fashion, keep track of changes to the patch (if
> necessary) also very cleanly, in a timeline sort of fashion, where changes
> to the patch as well as overall comments are chronologically ordered. Very
> easy to see how a patch evolves.
> 

We have a different process, that also allows us to comment on specific
lines of the patch.  It has worked well for us for the last 10 years.

> As a current committer on an incubating project that went from a
> GitHub-based project to an Apache project (incubator-apache-cordova), this
> issue resounds very strongly in me. I would love to help out in any way I
> can to get this figured out.
> 

What issue?  There are several git-related tasks in the INFRA issue
tracker (https://issues.apache.org/jira/browse/INFRA), including one
about allowing PMC's to interact with pull requests (in a manner other
than 'accept them unmodified').  If you want to help, just drop a line
to the infra list.

Daniel

> Cheers,
> Fil Maj
> 
> On 5/24/12 10:54 AM, "Greg Stein" <gstein@gmail.com> wrote:
> 
> >Git people,
> >
> >The community is discussing what to do about this particular approach
> >for sending a patch (we have a defined and published method for
> >sending a patch to our community). That is a separate thread, but
> >pending that... I have a separate meta/infra issue for you.
> >
> >The Subversion PMC does not seem to have access to manage our presence
> >on GitHub, yet people seem to believe it is a viable approach to send
> >us patches. At a minimum, the PMC needs a way to manage our presence
> >on GitHub: the description, the readme, pull requests, etc.
> >
> >I doubt that the PMC and community wants to shut this down, but *we*
> >are the ones to define our presence to the larger community. The
> >Subversion PMC is the group to manage pull requests, and other aspects
> >of our project. In short, this GitHub repository is representing
> >"Apache Subversion" without the PMC providing any actual oversight or
> >any mechanism to manage it.
> >
> >Please let us know our options for managing our GitHub presence.
> >
> >Thanks,
> >Greg Stein
> >VP, Apache Subversion
> >
> >On Thu, May 24, 2012 at 4:12 AM, Git at Apache <git@git.apache.org> wrote:
> >> GitHub user techtonik opened a pull request:
> >>
> >>    https://github.com/apache/subversion/pull/1
> >>
> >>    port to new style classes -
> >>http://stackoverflow.com/questions/54867/old...
> >>
> >>    
> >>http://stackoverflow.com/questions/54867/old-style-and-new-style-classes-
> >>in-python
> >>
> >> You can merge this pull request into a Git repository by running:
> >>
> >>    $ git pull https://github.com/techtonik/subversion patch-1
> >>
> >> Alternatively you can review and apply these changes as the patch at:
> >>
> >>    https://github.com/apache/subversion/pull/1.patch
> >>
> >> ----
> >> commit cb3fa71cceef1060b1074299dbdbd4fcf8fd6869
> >> Author: anatoly techtonik <techtonik@gmail.com>
> >> Date:   2012-05-24T01:12:03-07:00
> >>
> >>    port to new style classes -
> >>http://stackoverflow.com/questions/54867/old-style-and-new-style-classes-
> >>in-python
> >>
> >> ----
> >>
> 

Mime
View raw message