www-infrastructure-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Davis <paul.joseph.da...@gmail.com>
Subject Re: @apache.org commit address requirement (Was: Git hosting is go)
Date Wed, 14 Dec 2011 22:37:47 GMT
On Wed, Dec 14, 2011 at 4:29 PM, Brett Porter <brett@apache.org> wrote:
>
> On 15/12/2011, at 6:15 AM, Jukka Zitting wrote:
>
>> I'd treat those as social problems that are best solved by social
>> means. Introducing technical barriers will just force people to use
>> awkward workarounds when things like pull requests don't work like
>> they'd expect. After all, there are plenty of cases where people have
>> accidentally committed extra files or other garbage with Subversion. I
>> don't see much difference here.
>>
>> I wouldn't object to having the %ce check available as an option for
>> projects that want it or even enabled by default, but IMHO it
>> shouldn't be mandatory for all projects.
>
> I know for myself that I've far too often forgotten a git config on a new clone and accidentally
put @apache.org in a work repo or vice-versa, and seen a few <root@someserver-name>
crop up. I think the check is useful as a form of assistance, especially since you can't really
fix it once it is pushed, and not always obvious when committing.
>
> Is there a way to rebase a commit so the author is retained but the committer is adjusted
to the person approving it, so that these can be handled more easily?
>
> Worth noting - while I'm not sure if it is current, it appears that Eclipse require a
commit line match [1] (and even go a bit stricter [2]).
>
> The ICLA/email link would be ideal... or perhaps there is a compromise solution in the
mean time - for example, reading a list of email addresses from CONTRIBUTORS or pom.xml in
the top of the git repository that are allowed to commit, which you'd need to update first.
>

This is a decent short term solution that I'd be willing to
investigate. Though I would require that it be OOB from the actual
repository content.

> Cheers,
> Brett
>
> [1] http://wiki.eclipse.org/Git#Committers_new_to_Git
> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=324768
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
> http://twitter.com/brettporter
>
>
>
>
>

Mime
View raw message