www-builds mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Kuster <jasonkus...@google.com.INVALID>
Subject Re: Jenkins Github PR integration - Support for whitelisting?
Date Mon, 25 Sep 2017 17:58:33 GMT
Beam is also using the "official" plugin and has found it to be very useful
(it also allows us to trigger postcommit builds against pull requests if a
contributor wants to test something in more depth). All our jobs are
defined in the Job DSL in our repository[1].

[1] https://github.com/apache/beam/tree/master/.test-infra/jenkins

On Mon, Sep 25, 2017 at 4:20 AM, Ismael Juma <ismael@juma.me.uk> wrote:

> Hi,
>
> It is possible to use the plugin you call "official" too. It became
> available some time ago and we (Apache Kafka) switched to it once we found
> out. The easiest way is to look at our config:
>
> https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/
>
> Ismael
>
> On Mon, Sep 25, 2017 at 8:02 AM, Jaikiran Pai <jai.forums2013@gmail.com>
> wrote:
>
> > Hello Build Team,
> >
> > I'm one of the committers of the Apache Ant project[1]. We use Jenkins
> > hosted by the Infra team at builds.apache.org for automated triggering
> of
> > specific Jenkins jobs for pull requests that are submitted at the
> > (read-only) mirrors of the project hosted at github[2]. The Jenkins job
> is
> > a typical job that follows the steps noted in this article[3]. Things
> work
> > fine and here's the Jenkins job we have[4].
> >
> > However, a couple of things that seem to be missing when compared to the
> > "official" Jenkins Github integration plugin[5] are:
> >
> >     1. Ability to whitelist users who can submit a PR - this helps to
> > avoid random users from creating (potentially malicious) PRs which
> trigger
> > a job against Jenkins
> >
> >     2. Ability to issue a "retest this please" command (by whitelisted
> > users) as a comment on the PR to auto-trigger a new job for the PR.
> >
> > Are these features already available in the one that's hosted at
> > builds.apache.org and if so, is there some documentation I can follow?
> If
> > not, is there any workaround for #1 or any plans to support these
> features?
> >
> >
> > [1] http://ant.apache.org/
> >
> > [2] https://github.com/apache/ant-ivy
> >
> > [3] https://blogs.apache.org/infra/entry/github_pull_request_builds_now
> >
> > [4] https://builds.apache.org/job/Ivy-GithubPR/
> >
> > [5] https://github.com/jenkinsci/ghprb-plugin/blob/master/README.md
> >
> > -Jaikiran
> >
> >
> >
> >
>



-- 
-------
Jason Kuster
Apache Beam / Google Cloud Dataflow

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message