Mailing-List: contact apache-bugdb-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: apache-bugdb@apache.org
Date: 17 Oct 2001 00:20:46 -0000
Message-ID: <20011017002046.72853.qmail@apache.org>
To: apache-bugdb@apache.org, cconover@mmxi.com, ed@apache.org
From: ed@apache.org
Subject: Re: mod_jserv/6109: Apache dies, too many open files in error log

[In order for any reply to be added to the PR database, you need]
[to include <apbugs@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or      ]
["Re: general/1098:").  If the subject doesn't match this       ]
[pattern, your message will be misfiled and ignored.  The       ]
["apbugs" address is not added to the Cc line of messages from  ]
[the database automatically because of the potential for mail   ]
[loops.  If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request from a  ]
[developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]


Synopsis: Apache dies, too many open files in error log

State-Changed-From-To: open-feedback
State-Changed-By: ed
State-Changed-When: Tue Oct 16 17:20:46 PDT 2001
State-Changed-Why:
mod_jserv (as of 1.1.3) does indeed have a file descriptor leak.
It's related to the log files -- basically, the pool function
wasn't being used, and so no cleanup was happening.  The
following patch may resolve the issue:

*****
--- jserv_utils.c.orig  Tue Oct 16 17:00:42 2001
+++ jserv_utils.c       Tue Oct 16 17:00:57 2001
@@ -212,7 +212,7 @@
 #endif /* ifdef WIN32 */
 
     /* Open file and check */
-    filedesc=open(filename, flags, mode);
+    filedesc=ap_popenf(p, filename, flags, mode);
     if (filedesc==-1) {
         char *buf=ap_pstrcat(p,"file '",filename,"' can't be opened",NULL);
         return buf;
*****

This may at some point be committed to the JServ CVS tree, but
no further releases are planned.  I'm entering this information
in case someone else has problems with apache leaking file
descriptors during graceful restarts or ordinary restarts (
via the HUP or USR1 signals).
Release-Changed-From-To: 1.3.12-1.1.3
Release-Changed-By: ed
Release-Changed-When: Tue Oct 16 17:20:46 PDT 2001
Category-Changed-From-To: general-mod_jserv
Category-Changed-By: ed
Category-Changed-When: Tue Oct 16 17:20:46 PDT 2001