www-apache-bugdb mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Finch <...@dotat.at>
Subject Re: general/6711: byterange problems in 1.3.14
Date Tue, 31 Oct 2000 23:00:04 GMT
The following reply was made to PR general/6711; it has been noted by GNATS.

From: Tony Finch <dot@dotat.at>
To: new-httpd@apache.org
Cc: apbugs@apache.org
Subject: Re: general/6711: byterange problems in 1.3.14
Date: Tue, 31 Oct 2000 22:54:48 +0000

 Joe Orton <joe@light.plus.com> wrote:
 >On Tue, Oct 31, 2000 at 10:30:40PM +0000, Tony Finch wrote:
 >> The patch is broken. It introduces a new return value for
 >> internal_byterange but it doesn't change all the code that calls
 >> internal_byterange (directly or indirectly) to accommodate the change.
 >> e.g. default_handler calls ap_each_byterange assuming that the return
 >> value is boolean; ap_each_byterange is a wrapper around
 >> internal_byterange which does not return a boolean.
 >
 >I tried to cover this properly, as per the comment in
 >internal_byternage: the new return code is only used when realreq=0 is
 >passed in, i.e., only in the call from ap_set_byterange.
 >ap_each_byterange passes realreq=1 in, so the -1 will never get
 >returned... what am I missing?
 
 You are right -- I missed that. I'm looking at parse_byterange now
 because I think that may be the culprit.
 
 Tony.
 -- 
 en oeccget g mtcaa    f.a.n.finch
 v spdlkishrhtewe y    dot@dotat.at
 eatp o v eiti i d.    fanf@covalent.net

Mime
View raw message