Mailing-List: contact apache-bugdb-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: apache-bugdb@apache.org
Date: 12 Sep 2000 07:20:01 -0000
Message-ID: <20000912072001.70920.qmail@locus.apache.org>
To: apache-bugdb@apache.org
Cc: apache-bugdb@apache.org,
From: Sander van Zoest <sander@covalent.net>
Subject: general/5597: [PATCH] mod_mime.c RemoveHandler
Reply-To: Sander van Zoest <sander@covalent.net>

The following reply was made to PR general/5597; it has been noted by GNATS.

From: Sander van Zoest <sander@covalent.net>
To: apbugs@apache.org
Cc:  
Subject: general/5597: [PATCH] mod_mime.c RemoveHandler
Date: Tue, 12 Sep 2000 00:12:31 -0700 (PDT)

 As described in the above mentioned PR, the RemoveHandler directive acted
 as a global remove handler from all paths and vhosts for that process.
 
 Recently RemoveEncoding and RemoveType have been added in the same broken
 fashion.
 
 The attached patch is against the latest version of mod_mime.c in the
 apache-1.3 CVS tree.
 
 Cheers,
 
 --
 Sander van Zoest                                         [sander@covalent.net]
 Covalent Technologies, Inc.                           http://www.covalent.net/
 (415) 536-5218                                 http://www.vanzoest.com/sander/
 
 Index: mod_mime.c
 ===================================================================
 RCS file: /work/cvs/root/asf/httpd/apache-1.3/src/modules/standard/mod_mime.c,v
 retrieving revision 1.55
 diff -u -r1.55 mod_mime.c
 --- mod_mime.c	2000/07/14 17:34:32	1.55
 +++ mod_mime.c	2000/09/12 01:10:12
 @@ -157,15 +157,15 @@
  
      suffix = (attrib_info *) add->handlers_remove->elts;
      for (i = 0; i < add->handlers_remove->nelts; i++) {
 -        ap_table_unset(base->handlers, suffix[i].name);
 +        ap_table_unset(new->handlers, suffix[i].name);
      }
      suffix = (attrib_info *) add->types_remove->elts;
      for (i = 0; i < add->types_remove->nelts; i++) {
 -        ap_table_unset(base->forced_types, suffix[i].name);
 +        ap_table_unset(new->forced_types, suffix[i].name);
      }
      suffix = (attrib_info *) add->encodings_remove->elts;
      for (i = 0; i < add->encodings_remove->nelts; i++) {
 -        ap_table_unset(base->encoding_types, suffix[i].name);
 +        ap_table_unset(new->encoding_types, suffix[i].name);
      }
  
      new->type = add->type ? add->type : base->type;