www-apache-bugdb mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam Richter <a...@yggdrasil.com>
Subject general/6318: Apache 2.0a4 segfaults on config file syntax error
Date Mon, 17 Jul 2000 10:51:29 GMT

>Number:         6318
>Category:       general
>Synopsis:       Apache 2.0a4 segfaults on config file syntax error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Mon Jul 17 04:00:01 PDT 2000
>Originator:     adam@yggdrasil.com
>Release:        2.0a4
Linux adam 2.4.0-test4 #2 SMP Sun Jul 16 21:16:15 PDT 2000 i686 unknown
I have a patch for this, so you do not need to study the traceback too
carefully.  ap_read_config does not set parms.err_directive, but this
field is derefenced by the routine that prints error messages relating to
any syntax errors found.  So, instead, if apache core dumps when it tries
to print the error message.

#0  0x8054d0e in ap_process_resource_config (s=0x80842b4, 
    fname=0xbffffd55 "/etc/httpd/conf/httpd.conf", conftree=0xbffffbb8, 
    p=0x8083ef4, ptemp=0x8099fa4) at http_config.c:1322
#1  0x8055305 in ap_read_config (process=0x8081f14, ptemp=0x8099fa4, 
    confname=0xbffffd55 "/etc/httpd/conf/httpd.conf", conftree=0xbffffbb8)
    at http_config.c:1588
#2  0x8059452 in main (argc=3, argv=0xbffffc34) at http_main.c:383
#3  0x400c68fa in __libc_start_main (main=0x8059210 <main>, argc=3, 
    argv=0xbffffc34, init=0x804f568 <_init>, fini=0x807298c <_fini>, 
    rtld_fini=0x40009ef0 <_dl_fini>, stack_end=0xbffffc2c)
    at ../sysdeps/generic/libc-start.c:92
Retrieve ftp://ftp.yggdrasil.com/private/adam/for_apache/httpd.conf.broken
into a local file and run "httpd -f" on it.
Yes.  Here is a suggested patch.  Warning: all I did was stuff the undefined
field with the only value that I saw laying around that was of the same
data type.  I do not know if, for example, the line numbers in the resulting
error message are correct.

--- apache_2.0a4/src/main/http_config.c Sat Jun  3 09:27:03 2000
+++ apache/src/main/http_config.c       Mon Jul 17 03:36:19 2000
@@ -1317,6 +1317,7 @@
     parms.config_file = cfp;
     errmsg = ap_build_config(&parms, p, ptemp, conftree);
+    parms.err_directive = *conftree;
     if (errmsg != NULL) {
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]

View raw message