www-apache-bugdb mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eidelman, Brian" <BEidel...@netegrity.com>
Subject RE: mod_proxy/6055: PATCH: make mod_proxy deliver cookies set by other modules when used as ProxyPass
Date Fri, 05 May 2000 20:30:02 GMT
The following reply was made to PR mod_proxy/6055; it has been noted by GNATS.

From: "Eidelman, Brian" <BEidelman@netegrity.com>
To: "'submit@bugz.apache.org'" <submit@bugz.apache.org>, 
	"'apache-bugdb@apache.org'" <apache-bugdb@apache.org>
Cc:  
Subject: RE: mod_proxy/6055: PATCH:  make mod_proxy deliver cookies set by
	 other modules when used as ProxyPass
Date: Fri, 5 May 2000 16:31:33 -0400 

 This message is in MIME format. Since your mail reader does not understand
 this format, some or all of this message may not be legible.
 
 ------_=_NextPart_001_01BFB6D0.E804675E
 Content-Type: text/plain;
 	charset="iso-8859-1"
 
 I relized that inserting the err_headers_out table as part of
 ap_proxy_read_headers messes up error checking further on.  I now submit
 that err_headers_out should be added to resp_hdrs in proxy_http.c right
 after the connection headers are stripped.  Here is the new patch
 
 PATCH:
 
 [beidelma]>diff -C3 proxy_http-old.c proxy_http.c
 *** proxy_http-old.c    Fri May  5 16:13:37 2000
 --- proxy_http.c        Fri May  5 16:14:13 2000
 ***************
 *** 481,486 ****
 --- 481,488 ----
         }
   
         clear_connection(p, resp_hdrs); /* Strip Connection hdrs */
 +       /* Now add out bound headers set by other modules 
 +       resp_hdrs = ap_overlay_tables(r->pool, r->err_headers_out,
 resp_hdrs);
       }
       else {
   /* an http/0.9 response */
 
 ------_=_NextPart_001_01BFB6D0.E804675E
 Content-Type: text/html;
 	charset="iso-8859-1"
 Content-Transfer-Encoding: quoted-printable
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
 <HTML>
 <HEAD>
 <META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
 charset=3Diso-8859-1">
 <META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
 5.5.2650.12">
 <TITLE>RE: mod_proxy/6055: PATCH:  make mod_proxy deliver cookies set =
 by other modules when used as ProxyPass</TITLE>
 </HEAD>
 <BODY>
 
 <P><FONT SIZE=3D2>I relized that inserting the err_headers_out table as =
 part of ap_proxy_read_headers messes up error checking further =
 on.&nbsp; I now submit that err_headers_out should be added to =
 resp_hdrs in proxy_http.c right after the connection headers are =
 stripped.&nbsp; Here is the new patch</FONT></P>
 
 <P><FONT SIZE=3D2>PATCH:</FONT>
 </P>
 
 <P><FONT SIZE=3D2>[beidelma]&gt;diff -C3 proxy_http-old.c =
 proxy_http.c</FONT>
 <BR><FONT SIZE=3D2>*** proxy_http-old.c&nbsp;&nbsp;&nbsp; Fri May&nbsp;
=
 5 16:13:37 2000</FONT>
 <BR><FONT SIZE=3D2>--- =
 proxy_http.c&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Fri May&nbsp;
5 =
 16:14:13 2000</FONT>
 <BR><FONT SIZE=3D2>***************</FONT>
 <BR><FONT SIZE=3D2>*** 481,486 ****</FONT>
 <BR><FONT SIZE=3D2>--- 481,488 ----</FONT>
 <BR><FONT SIZE=3D2>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
}</FONT>
 <BR><FONT SIZE=3D2>&nbsp; </FONT>
 <BR><FONT SIZE=3D2>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
=
 clear_connection(p, resp_hdrs); /* Strip Connection hdrs */</FONT>
 <BR><FONT SIZE=3D2>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
/* Now add out =
 bound headers set by other modules </FONT>
 <BR><FONT SIZE=3D2>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
resp_hdrs =3D =
 ap_overlay_tables(r-&gt;pool, r-&gt;err_headers_out, resp_hdrs);</FONT>
 <BR><FONT SIZE=3D2>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }</FONT>
 <BR><FONT SIZE=3D2>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; else {</FONT>
 <BR><FONT SIZE=3D2>&nbsp; /* an http/0.9 response */</FONT>
 </P>
 
 </BODY>
 </HTML>
 ------_=_NextPart_001_01BFB6D0.E804675E--

Mime
View raw message