www-apache-bugdb mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anders Dinsen <...@lasat.com>
Subject mod_proxy/5333: ProxyVia full does not include module names in Via: header comment
Date Thu, 18 Nov 1999 11:22:55 GMT

>Number:         5333
>Category:       mod_proxy
>Synopsis:       ProxyVia full does not include module names in Via: header comment
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Thu Nov 18 03:30:01 PST 1999
>Last-Modified:
>Originator:     adi@lasat.com
>Organization:
apache
>Release:        1.3.9
>Environment:
Linux mq 2.0.38 #1 Tue Sep 14 12:37:00 CEST 1999 i586 unknown
>Description:
With "ProxyVia full" on, I expected the Via: header to include names and
versions of modules that has called ap_add_version_comment() to be included
in the comment (so it would be consistent with the Server: header).

This is the Via: header of 1.3.9 (with ProxyVia full):
Via: 1.1 proxy.example.com (Apache/1.3.9)

This is what I'd like the Via: header to contain:
Via: 1.1 proxy.example.com (Apache/1.3.9 (Unix) mod_perl/1.21)

>How-To-Repeat:

>Fix:
--- apache_1.3.9/src/modules/proxy/proxy_http.c.orig    Thu Nov 18 11:06:08 1999
+++ apache_1.3.9/src/modules/proxy/proxy_http.c Thu Nov 18 11:37:06 1999
@@ -328,7 +328,7 @@
                                HTTP_VERSION_MAJOR(r->proto_num),
                                HTTP_VERSION_MINOR(r->proto_num),
                                ap_get_server_name(r), portstr,
-                               SERVER_BASEVERSION)
+                               ap_get_server_version())
                        : ap_psprintf(p, "%d.%d %s%s",
                                HTTP_VERSION_MAJOR(r->proto_num),
                                HTTP_VERSION_MINOR(r->proto_num),
@@ -427,7 +427,7 @@
                            ? ap_psprintf(p, "%d.%d %s%s (%s)",
                                major, minor,
                                ap_get_server_name(r), portstr,
-                               SERVER_BASEVERSION)
+                               ap_get_server_version())
                            : ap_psprintf(p, "%d.%d %s%s",
                                major, minor,
                                ap_get_server_name(r), portstr)
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <apbugs@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or      ]
["Re: general/1098:").  If the subject doesn't match this       ]
[pattern, your message will be misfiled and ignored.  The       ]
["apbugs" address is not added to the Cc line of messages from  ]
[the database automatically because of the potential for mail   ]
[loops.  If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request from a  ]
[developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]




Mime
View raw message