www-apache-bugdb mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Guenther <guent...@gac.edu>
Subject mod_jserv/4298: jserv_image array should be of "unsigned char"
Date Fri, 23 Apr 1999 19:06:51 GMT

>Number:         4298
>Category:       mod_jserv
>Synopsis:       jserv_image array should be of "unsigned char"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jserv
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Fri Apr 23 12:10:01 PDT 1999
>Last-Modified:
>Originator:     guenther@gac.edu
>Organization:
apache
>Release:        apache 1.3.6 + ApacheJServ/1.0b3
>Environment:
Solaris 2.6, Sun cc (WorkShop Compilers 4.2.1)
>Description:
char is signed under Solaris with sun's cc, so that compilation of
jserv_image.c fails:

./jserv_mkimg jserv.gif jserv_image.c
cc -c  -I../../os/unix -I../../include   -DSOLARIS2=260 -DTARGET=\"apache\" -DRAVEN_SSL -O
-dalign -native -xlibmil -DDYNAMIC_MODULE_LIMIT=0 -g `../../apaci` jserv_image.c
"jserv_image.c", line 4: warning: initializer does not fit or is out of range: 213
"jserv_image.c", line 8: warning: initializer does not fit or is out of range: 183
"jserv_image.c", line 9: warning: initializer does not fit or is out of range: 255
"jserv_image.c", line 9: warning: initializer does not fit or is out of range: 143
"jserv_image.c", line 9: warning: initializer does not fit or is out of range: 233
...
"jserv_image.c", line 189: warning: initializer does not fit or is out of range: 205
"jserv_image.c", line 189: warning: initializer does not fit or is out of range: 169
cc: acomp failed for jserv_image.c
gmake[2]: *** [jserv_image.o] Error 2
>How-To-Repeat:
Uh, find a Solaris box with sun's cc and give it a shot.
>Fix:
*** Apache-JServ-1.0b3/src/c/jserv_mkimg.c      Thu Jan 14 14:44:22 1999
--- ../Apache-JServ-1.0b3/src/c/jserv_mkimg.c   Tue Apr 13 18:02:08 1999
***************
*** 79,85 ****
      }
  
      fputs("#include \"jserv.h\"\n\n",out);
!     fputs("char jserv_image[]={\n    ",out);
  
      y=fgetc(in);
      while (!feof(in)) {
--- 79,85 ----
      }
  
      fputs("#include \"jserv.h\"\n\n",out);
!     fputs("unsigned char jserv_image[]={\n    ",out);
  
      y=fgetc(in);
      while (!feof(in)) {
*** Apache-JServ-1.0b3/src/c/jserv.h    Fri Feb 19 12:59:10 1999
--- ../Apache-JServ-1.0b3/src/c/jserv.h Fri Apr 23 09:57:47 1999
***************
*** 128,134 ****
  #endif /* ifndef WIN32 */
  
  /* Image */
! extern char jserv_image[];
  extern long jserv_image_size;
  
  /*****************************************************************************
--- 128,134 ----
  #endif /* ifndef WIN32 */
  
  /* Image */
! extern unsigned char jserv_image[];
  extern long jserv_image_size;
  
  /*****************************************************************************
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.                                      ]
[Reply only with text; DO NOT SEND ATTACHMENTS!         ]




Mime
View raw message