www-apache-bugdb mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Snabb <sn...@epipe.fi>
Subject Re: os-osf/2449: quotes missing from $CFG_LDFLAGS_SHLIB in apxs in OSF1
Date Tue, 16 Jun 1998 09:50:00 GMT
The following reply was made to PR os-osf/2449; it has been noted by GNATS.

From: Janne Snabb <snabb@epipe.fi>
To: apbugs@hyperreal.org, apache-bugdb@apache.org
Cc:  Subject: Re: os-osf/2449: quotes missing from $CFG_LDFLAGS_SHLIB in apxs in OSF1
Date: Tue, 16 Jun 1998 12:47:00 +0300 (EEST)

 I did some more debugging of the problem, and found out a simple fix:
 
 --- apxs.pl.dist	Tue Jun 16 12:37:32 1998
 +++ apxs.pl	Tue Jun 16 12:37:47 1998
 @@ -211,11 +211,11 @@
      my (@cmds) = @_;
      my ($cmd, $rc);
  
      foreach $cmd (@cmds) {
          print STDERR "$cmd\n";
 -        $rc = system("$cmd");
 +        $rc = system(split(' ', $cmd));
          if ($rc != 0) {
              printf(STDERR "apxs:Break: Command failed with rc=%d\n", $rc << 8);
              exit(1);
          }
      }
 
 ...although I don't know if this breaks apxs on some other platforms,
 but I assume that apxs commands don't have to be passed throuhg /bin/sh in
 any situation. (BTW, why was the system() argument string $cmd surrounded
 with the double-quotes anyway? :-)
 
 --
 Janne Snabb / Broken Pipe Oy
 snabb@epipe.fi
 

Mime
View raw message