The following reply was made to PR mod_negotiation/1772; it has been noted by GNATS.
From: Dean Gaudet <dgaudet@arctic.org>
To: "Roy T. Fielding" <fielding@kiwi.ics.uci.edu>
Cc: Ronald Tschalaer <Ronald.Tschalaer@psi.ch>, apbugs@hyperreal.org
Subject: Re: mod_negotiation/1772: Can't handle both "Accept-Encoding: gzip" and "Accept-Encoding:
x-gzip"
Date: Thu, 5 Feb 1998 12:54:29 -0800 (PST)
On Thu, 5 Feb 1998, Roy T. Fielding wrote:
> >> ! if (!strncmp(name, "x-", 2))
>
> sucks performance-wise when compared to
>
> if (name[1] == '-' && (name[0] == 'x' || name[0] == 'X'))
Heh. This is exactly what I did in my working copy of Ronald's patch
already.
Actually I think in mod_negotiation we're guaranteed that everything is
lower case. I need to double check that again... it seemed to be correct
when I was looking at case-sensitivity.
Dean
|