Return-Path: 
 <apache-bugdb-owner-apache-bugdb-archive=hyperreal.org@apache.org>
Delivered-To: apache-bugdb-archive@hyperreal.org
Received: (qmail 2133 invoked by uid 6000); 4 Nov 1997 00:20:07 -0000
Received: (qmail 2090 invoked by uid 2001); 4 Nov 1997 00:20:00 -0000
Received: (qmail 1907 invoked by uid 2012); 4 Nov 1997 00:18:32 -0000
Message-Id: <19971104001832.1906.qmail@hyperreal.org>
Date: 4 Nov 1997 00:18:32 -0000
From: M.D.Parker <mdpc@netcom.com>
Reply-To: mdpc@netcom.com
To: apbugs@hyperreal.org
X-Send-Pr-Version: 3.2
Subject: mod_cgi/1352: Errors Logged by mod_cgi.c FAIL to report filename
Sender: apache-bugdb-owner@apache.org
Precedence: bulk


>Number:         1352
>Category:       mod_cgi
>Synopsis:       Errors Logged by mod_cgi.c FAIL to report filename
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Mon Nov  3 16:20:00 PST 1997
>Last-Modified:
>Originator:     mdpc@netcom.com
>Organization:
apache
>Release:        1.3b2
>Environment:
UNIX (Various)
>Description:
A coding issue in the mod_cgi.c module prevents the proper display in the error
log file of the filename causing a specific error.  
>How-To-Repeat:
Yes, easily.
>Fix:
Analysis shows that the aplog_error is not being called correctly from the 
subroutine  log_scripterror().  The "fmt" argument is missing.

diff -c to correct this problem is:

*** mod_cgi.c   Mon Nov  3 16:08:49 1997
--- mod_cgi.c.dist      Mon Nov  3 15:51:34 1997
***************
*** 163,169 ****
  {
      FILE *f;

!     aplog_error(APLOG_MARK, show_errno|APLOG_ERR, r->server, "%s -- %s", error,
                r->filename);

      if (!conf->logname ||
--- 163,169 ----
  {
      FILE *f;

!     aplog_error(APLOG_MARK, show_errno|APLOG_ERR, r->server, error,
                r->filename);

      if (!conf->logname ||
%0
>Audit-Trail:
>Unformatted: