Date: Wed, 14 May 1997 01:20:21 -0700 (MST)
From: Jack Holt <holt@smarthealth.com>
To: Dean Gaudet <dgaudet@arctic.org>
Cc: apache-bugdb@apache.org
Subject: Re: mod_dir/576: Port 0 being added in directory redirects
In-Reply-To: <Pine.LNX.3.95dg3.970513163312.21777J-100000@twinlark.arctic.org>
Message-Id: <Pine.NXT.3.95.970514011535.5828B-100000@asthma>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: apache-bugdb-owner@apache.org
Precedence: bulk


On Tue, 13 May 1997, Dean Gaudet wrote:

> Oh when I looked at the config you posted I thought it did have
> _default_:80.  If it has _default_:* then this problem is entirely
> expected.  Stick a Port 80 into the default server, and/or try out this
> little patch: 
> 
> Dean

Mea culpa.  There was a bug in my bug report.  That's what I get for
retyping instead of cutting and pasting.

I will probably just ":80" for now, but thank you for the patch:
it may be useful in the future, depending on our needs.

Also, thanks to you and the other members of the Apache team.
I am impressed by how quickly you all have responded to, and resolved,
bug reports.  Let's see Microsoft or Netscape try to do even half
as well!

	--Jack

> 
> Index: http_config.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_config.c,v
> retrieving revision 1.48
> diff -u -r1.48 http_config.c
> --- http_config.c	1997/04/12 04:24:56	1.48
> +++ http_config.c	1997/05/13 18:53:08
> @@ -957,7 +957,12 @@
>      /* terminate the list */
>      *addrs = NULL;
>      if( s->addrs ) {
> -	s->port = s->addrs->host_port;  /* set them the same, by default */
> +	if (s->addrs->host_port) {
> +	    s->port = s->addrs->host_port;  /* set them the same, by default */
> +	} else {
> +	    /* otherwise we get a port of 0 on redirects */
> +	    s->port = main_server->port;
> +	}
>      }
>      s->next = NULL;
> 
>