ws-xmlrpc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject cvs commit: xml-rpc/src/java/org/apache/xmlrpc XmlRpcServer.java
Date Sat, 26 Jan 2002 07:50:42 GMT
dlr         02/01/25 23:50:42

  Modified:    src/java/org/apache/xmlrpc XmlRpcServer.java
  Log:
  Timothy Peierls <tim@peierls.net> makes a good point about my merge of
  his patch:
  
  I notice you left the byte[] result as a field rather than make it a
  local variable. Though it won't make any difference for small
  responses, it is still a potential memory leak if the responses get
  very large.
  
  Revision  Changes    Path
  1.8       +1 -1      xml-rpc/src/java/org/apache/xmlrpc/XmlRpcServer.java
  
  Index: XmlRpcServer.java
  ===================================================================
  RCS file: /home/cvs/xml-rpc/src/java/org/apache/xmlrpc/XmlRpcServer.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -u -r1.7 -r1.8
  --- XmlRpcServer.java	25 Jan 2002 23:03:58 -0000	1.7
  +++ XmlRpcServer.java	26 Jan 2002 07:50:42 -0000	1.8
  @@ -152,7 +152,6 @@
       {
           Vector inParams;
           StringBuffer strbuf;
  -        byte[] result;
   
           /**
            * Creates a new instance.
  @@ -184,6 +183,7 @@
           private byte[] executeInternal (InputStream is, String user,
                                           String password)
           {
  +            byte[] result;
               long now = System.currentTimeMillis ();
   
               try
  
  
  

Mime
View raw message