Return-Path: Delivered-To: apmail-ws-wss4j-dev-archive@www.apache.org Received: (qmail 90922 invoked from network); 14 Oct 2006 02:52:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Oct 2006 02:52:01 -0000 Received: (qmail 97839 invoked by uid 500); 14 Oct 2006 02:51:06 -0000 Delivered-To: apmail-ws-wss4j-dev-archive@ws.apache.org Received: (qmail 97728 invoked by uid 500); 14 Oct 2006 02:51:06 -0000 Mailing-List: contact wss4j-dev-help@ws.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list wss4j-dev@ws.apache.org Received: (qmail 97673 invoked by uid 99); 14 Oct 2006 02:51:06 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2006 19:51:06 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2006 19:51:02 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9872C714325 for ; Fri, 13 Oct 2006 19:50:17 -0700 (PDT) Message-ID: <1551980.1160794217621.JavaMail.jira@brutus> Date: Fri, 13 Oct 2006 19:50:17 -0700 (PDT) From: "Bob Coss (JIRA)" To: wss4j-dev@ws.apache.org Subject: [jira] Commented: (WSS-54) UsernameTokenProcessor not processing unhashed UsernameToken In-Reply-To: <7485135.1156862242480.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/WSS-54?page=comments#action_12442209 ] Bob Coss commented on WSS-54: ----------------------------- [[ Old comment, sent by email on Tue, 29 Aug 2006 10:28:05 -0500 ]] That doesn't seem to make sense to me the way this is handled. According to the way the callback is being processed, the only thing that can be thrown is a UnsupportedCallbackException() or IOException. In UsernameTokenProcessor, it will throw: throw new WSSecurityException(WSSecurityException.FAILURE, "noPassword", new Object[]{user}); and not a WSSecurityException(WSSecurityException.FAILED_AUTHENTICATION). In the spirit of JAAS, shouldn't the handler be providing the value of the password to the callback, and the UsernameTokoenProcessor evaluating the password supplied in the token with the one from application? > UsernameTokenProcessor not processing unhashed UsernameToken > ------------------------------------------------------------ > > Key: WSS-54 > URL: http://issues.apache.org/jira/browse/WSS-54 > Project: WSS4J > Issue Type: Bug > Reporter: Bob Coss > Assigned To: Davanum Srinivas > > The UsernameTokenProcessor will not authenticate anything but a UsernameToken that was hashed with a nonce and timestamp. Anything else that is passed to it will create a valid principal regardless of what the implementations password callback handler does. This is creating confusion and preventing WSS4J from being used for anything where the the UsernameToken is passed plainly. It is understood that doing this in a production environment is discouraged, but it is usefull to have this implementation work as expected so that the framework can be experimented with and evaluated. > Specifically, in UsernameTokenProcessor.java, for a UsernameToken that is not of hashed, nothing is done with the WSPasswordCallback object after the call to the password handler handle method is invoked. Since nothing is done with it, the code drops through and sets up a valid principal with the userid and returns. There is no way to signal a WSSecurityException(WSSecurityException.FAILED_AUTHENTICATION). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org For additional commands, e-mail: wss4j-dev-help@ws.apache.org