ws-woden-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Kaputin (gmail)" <jakapu...@gmail.com>
Subject Re: WODEN-3 Schema-0016 contribution
Date Wed, 13 Jun 2007 16:31:31 GMT
Sriram,
I've been away for a couple of weeks, but have now followed up on Arthur's
posts regarding WODEN-3.

I have renumbered assertion Schema-0016 to Schema-1066 via WODEN-149. I have
also uploaded a new patch for Messages.properties to WODEN-3 with an
improved message for Schema-1066.  Would you like to apply that patch file
to your development sandbox and then redo your patches for
WSDLDocumentValidator and WSDLDocumentValidatorTest? (remember to check that
your new patch files contain only your changes).

thanks,
John Kaputin.

On 5/25/07, Arthur Ryman <ryman@ca.ibm.com> wrote:
>
>
> John,
>
> The assertion was renamed to Schema-1066.
>
> Recall that I provided a rename Ant script :-)
>
>         <target name="renumber-assertions">
>                 <xslt style="renumber-assertions.xsl" in="wsdl20.xml" out=
> "renumber-assertions-1.properties" />
>                 <xslt style="renumber-assertions.xsl" in="
> wsdl20-adjuncts.xml" out="renumber-assertions-2.properties" />
>         </target>
>
> Did you apply this to the Woden code yet? If not, shall I?
>
> The script uses propertie files for Part 1 [1] and Part 2 [2].
>
> [1]
> http://dev.w3.org/cvsweb/2002/ws/desc/wsdl20/renumber-assertions-1.properties
> [2]
> http://dev.w3.org/cvsweb/2002/ws/desc/wsdl20/renumber-assertions-2.properties
>
> Arthur Ryman, PhD, AoT, DE
> Process and Portfolio Management, Rational Division
>
> phone: +1-905-413-3077, TL 969-3077
> assistant: +1-905-413-3831 (T/L: 318-8867)
> fax: +1-905-413-4920, TL 969-4920
> mobile: +1-416-939-5063, text: 4169395063@fido.ca
>
>
>
>
>  *John Kaputin <KAPUTIN@uk.ibm.com>*
>
> 05/25/2007 09:34 AM  Please respond to
> woden-dev@ws.apache.org
>
>   To
> woden-dev@ws.apache.org  cc
>
>  Subject
> Re: WODEN-3 Schema-0016 contribution
>
>
>
>
>
>
> Sriram,
> I just started on your patch files for WODEN-3 and have now found out that
>
> assertion Schema-0016 has been removed from the WSDL2 spec. I'm sorry I
> didn't realize this before asking you to work on it.  I'm not sure when or
>
> why it was remove. I looked through the W3C WSDL2 CR issues list at [1]
> but couldn't find any specific reference to Schema-0016 being removed. I
> think it might have been related to issues CR145 or CR154, which were
> dealt with quite late in the Candidate Recommendation phase. I will close
> WODEN-3.  There's no need for a JIRA to remove the Schema-0016 code as the
>
> Validator classes will be replaced by some new plugin / extension
> mechanism soon and all of the spec assertions will need to be implemented
> / re-implemented in Woden at that time. For now, I'll just comment out the
>
> call for this Schema-0016 assertion.
>
> BTW, there was a slight problem with your patch files.  They contained
> some modified lines unrelated to WODEN-3 that were not part of the
> required code changes, but appeared in the patch files in because the
> trailing characters appeared to have changed. Probably a problem with end
> of line characters in the editor you were using. Perhaps you could check
> any future patch files before uploading to JIRA to ensure they contain
> only your expected changes. Thanks.
>
> [1] http://www.w3.org/2002/ws/desc/5/cr-issues/issues.html
>
> Arthur posted a couple of days ago offerring help on WODEN-32, so that
> might be the best option if you'd like something else to work on.
>
> Woden-devs -  I'm away next week, so can you please help Sriram in my
> absence if anything comes up on the mailing list.
>
> thanks.
> John Kaputin
>
>
> "sriram m" <sriramrao1@gmail.com> wrote on 17/05/2007 18:51:47:
>
> > John,
> >
> >            The WODEN-3 JIRA has been updated with the patch files.
> >
> >   When you add documentation for new dev, please add the requirement
> > that the code needs to be under Subversion (on any such SCM tool)
> > for patch generation. I had to back out the changes I'd made and
> > start the process all over, for the Subversion tool to generate the
> > patch files.
> >
> >  I had sent a note to Arthur Ryman about frag-ids - he mentioned
> > that he will provide me info on a related JIRA. I havent heard back
> > from him yet.
> >
> >  I'll wait for your feedback on this (WODEN-3) JIRA changes. Was
> > there anything else that I can may be take a look at?
> >
> >     Sriram
> >
> >
> >
> > On 5/15/07, John Kaputin <KAPUTIN@uk.ibm.com> wrote:
> > Sriram,
> > thanks for making your first Woden contribution - a great first step!
> > Could you please use this process to contribute code:
> > 1. add your description of the change as a comment to JIRA WODEN-3
> > 2. create a patch file showing the code differences and upload this to
> > WODEN-3
> >
> > If you have not already signed up for a JIRA ID, you can do so by
> clicking
> > 'login' (top right) and 'signup'.
> >
> > JIRA allows the developer community to easily track contributions and
> > maintain history. The patch file makes it easy to see what the changes
> are
> > and can be applied to the existing code, rather that just replacing the
> > entire existing file(s).
> >
> > For testing take a look at
> > WSDLDocumentValidatorTest.testTestAssertionSchema0016(). You can run
> this
> > with Junit.
> >
> > I will do some developer documentation, but unfortunately that's
> unlikely
> > to happen until later next week.
> >
> > thanks,
> > John Kaputin
> >
> >
> > "sriram m" <sriramrao1@gmail.com> wrote on 14/05/2007 16:55:02:
> >
> > > John,
> > >
> > >         Per your previous email, I took a look at the Woden-3 JIRA.
> > > The JIRA seemed self-contained as you mentioned and simple for me
> > > start with. I have made the necessary changes. Please read below for
> > > the changes
> > >
> >
>
> *******************************************************************************
> > > WODEN-3
> > > Change Description:
> > > As described in the relevant JIRA(WODEN-3), I have modified
> > > testAssertionSchema0016 method to accept a QName instead of a
> > > namespaceURI. Within the method, I get the NameSpaceURI and the
> > > localpart from the QName supplied. The reportError will then use
> > > both the namespace and the localpart to log an error.
> > > The error message has been modified to
> > > "Schema-0016 = The component ''{1}'' refers to the XML Schema
> > > namespace ''{0}''. But this namespace is not available. In order to
> > > reference components from a XML Schema namespace the namespace must
> > > be imported or defined inline."
> > > with the {1} referring to the local part and {0} referring to the
> > namespace.
> > > I have also modified the 2 calls to this testAssertionSchema0016
> > > method to send QName instead of the namespaceURI.
> > >
> > > John - I have not tested this against any WSDL or a JUnit test case.
> > > I was hoping you would walk me through how you guys do that on this
> > > project (refers back to the developer guide I was looking for). I
> > > have attached the modified Class WSDLDocumentValidator and the
> > > Messages.properties files with this email.
> > >
> >
>
> *******************************************************************************
> > >
> > > Next Steps: I will test these changes once I hear back from you.
> > > Since I do not have "commit" rights, I believe some one will review
> > > these changes and commit it to the source upon testing.
> > >
> > > Regards,
> > >                Sriram
> > >  [attachment "WSDLDocumentValidator.java" deleted by John
> > > Kaputin/UK/IBM] [attachment "Messages.properties" deleted by John
> > > Kaputin/UK/IBM]
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: woden-dev-help@ws.apache.org
> >
> >
> >
> >
> >
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with number
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
> >
> >
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>
>
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>
>

Mime
View raw message