ws-sandesha-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amila Chinthaka Suriarachchi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2-4619) DeploymentFileData missing NULL check -- NullPointerException guaranteed from DeploymentEngine.buildServiceGroup
Date Sun, 02 May 2010 14:58:56 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863142#action_12863142
] 

Amila Chinthaka Suriarachchi commented on AXIS2-4619:
-----------------------------------------------------

this seems to be going to happen only if user put a services.xml to WEB-INF folder and try
to deploy. Hence it is a very rear case.

> DeploymentFileData missing NULL check -- NullPointerException guaranteed from DeploymentEngine.buildServiceGroup
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-4619
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4619
>             Project: Axis2
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>         Environment: * Java:
>      java version "1.6.0_16"
>      Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
>      Java HotSpot(TM) Client VM (build 14.2-b01, mixed mode, sharing)
> * Eclipse Dynamic Web Project
> * Apache Axis2 v1.5.1
>            Reporter: Dave Lindquist
>
> The class DeploymentFileData has the following interesting lines of code:
>     public class DeploymentFileData {
>         ...
>         public DeploymentFileData(File file) {
>             this.file = file;
>         }
>         ...
>         public String getName() {
>             return file.getName(); // No need to check for null due to constructor check
>         }
> Note the comment, and the lack of any check in the constructor!
> Moreover, in DeploymentEngine, in the buildServiceGroup method, the VERY FIRST LINE (1103)
says:
>         DeploymentFileData currentDeploymentFile = new DeploymentFileData(null, null);
> in other words, guaranteed NullPointerException if you call this method!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message