Return-Path: Delivered-To: apmail-ws-sandesha-dev-archive@www.apache.org Received: (qmail 32595 invoked from network); 17 Sep 2007 09:40:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Sep 2007 09:40:19 -0000 Received: (qmail 76078 invoked by uid 500); 17 Sep 2007 09:40:11 -0000 Delivered-To: apmail-ws-sandesha-dev-archive@ws.apache.org Received: (qmail 76026 invoked by uid 500); 17 Sep 2007 09:40:11 -0000 Mailing-List: contact sandesha-dev-help@ws.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list sandesha-dev@ws.apache.org Received: (qmail 76015 invoked by uid 500); 17 Sep 2007 09:40:11 -0000 Delivered-To: apmail-ws-sandesha-cvs@ws.apache.org Received: (qmail 76012 invoked by uid 99); 17 Sep 2007 09:40:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2007 02:40:11 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2007 09:42:08 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id F302B1A9832; Mon, 17 Sep 2007 02:39:55 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r576330 - /webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java Date: Mon, 17 Sep 2007 09:39:55 -0000 To: sandesha-cvs@ws.apache.org From: sumedha@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20070917093955.F302B1A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sumedha Date: Mon Sep 17 02:39:54 2007 New Revision: 576330 URL: http://svn.apache.org/viewvc?rev=576330&view=rev Log: No need to retrive senderBean. It is already retrived inside run() & passed to updateMessage. If we do this, we loose the original reference to senderBean Modified: webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java Modified: webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java URL: http://svn.apache.org/viewvc/webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java?rev=576330&r1=576329&r2=576330&view=diff ============================================================================== --- webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java (original) +++ webservices/sandesha/branches/sandesha2/java/1_3/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java Mon Sep 17 02:39:54 2007 @@ -395,7 +395,9 @@ private boolean updateMessage(RMMsgContext rmMsgContext, SenderBean senderBean, StorageManager storageManager) throws AxisFault { // Lock the message to enable retransmission update - senderBean = storageManager.getSenderBeanMgr().retrieve(senderBean.getMessageID()); + // No need to do the following. This is being done inside run(), which is the callee of + // updateMessage() + //senderBean = storageManager.getSenderBeanMgr().retrieve(senderBean.getMessageID()); // Only continue if we find a SenderBean if (senderBean == null) --------------------------------------------------------------------- To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org For additional commands, e-mail: sandesha-dev-help@ws.apache.org