ws-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WSS-629) Support additional elements in SubjectConfirmationData
Date Wed, 30 May 2018 09:18:00 GMT

    [ https://issues.apache.org/jira/browse/WSS-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494921#comment-16494921
] 

Colm O hEigeartaigh commented on WSS-629:
-----------------------------------------

Looks fine, but there are a few changes I'd like to see:

1) Add support in SAML2ComponentBuilder for the "Any" object to be an XMLObject. It can then
be set directly on the subjectConfirmationDataBean.

2) If the "Any" object is not one of XMLObject or AttributeStatementBean then log a warning.

3) Add a test. See for example this test for a custom AttributeValue:

https://github.com/apache/wss4j/blob/58bc1da96920c3b59c62ca21f94dbc3e01bf6436/ws-security-dom/src/test/java/org/apache/wss4j/dom/saml/SamlTokenTest.java#L580

 

> Support additional elements in SubjectConfirmationData
> ------------------------------------------------------
>
>                 Key: WSS-629
>                 URL: https://issues.apache.org/jira/browse/WSS-629
>             Project: WSS4J
>          Issue Type: Improvement
>          Components: WSS4J Core
>    Affects Versions: 2.2.1
>            Reporter: Dmytro Rud
>            Assignee: Colm O hEigeartaigh
>            Priority: Major
>             Fix For: 2.2.2
>
>         Attachments: 20180529.patch
>
>
> According to the XML Schema, SubjectConfirmationDataType can have arbitrary extensibility
elements.  The attached patch provides support for them.
>  (Currently, the only properly handled type of such extensibility elements is AttributeStatement.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


Mime
View raw message