Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6FF95200CBF for ; Sat, 8 Jul 2017 17:43:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6E7D316B0B0; Sat, 8 Jul 2017 15:43:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B50E016B0AF for ; Sat, 8 Jul 2017 17:43:03 +0200 (CEST) Received: (qmail 75831 invoked by uid 500); 8 Jul 2017 15:43:02 -0000 Mailing-List: contact dev-help@ws.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ws.apache.org Delivered-To: mailing list dev@ws.apache.org Received: (qmail 75820 invoked by uid 99); 8 Jul 2017 15:43:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jul 2017 15:43:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3ABFCC17B0 for ; Sat, 8 Jul 2017 15:43:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6Yov_abpe0nX for ; Sat, 8 Jul 2017 15:43:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 58C6D5FB06 for ; Sat, 8 Jul 2017 15:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B91E0E0D71 for ; Sat, 8 Jul 2017 15:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 166A524699 for ; Sat, 8 Jul 2017 15:43:00 +0000 (UTC) Date: Sat, 8 Jul 2017 15:43:00 +0000 (UTC) From: "Alexandru-Constantin Bledea (JIRA)" To: dev@ws.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (WSS-610) WSSecurityUtil.decodeAction misbehaving when sending NoSecurity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 08 Jul 2017 15:43:04 -0000 [ https://issues.apache.org/jira/browse/WSS-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandru-Constantin Bledea updated WSS-610: -------------------------------------------- Description: The decode method from org.apache.wss4j.dom.util.WSSecurityUtil doesn't appear to do the right thing when sending NoSecurity. If we're sending for instance "UsernameToken NoSecurity Signature" we're getting back [1] From my point of view, it should probably return [1, 0, 2]. However, it seems like the person who wrote that code wanted NoSecurity to override any other security policy (just like org.apache.ws.security.util.WSSecurityUtil's decodeAction), in that case it should probably return just [0], but stopping at what we already parsed up to now and not including NoSecurity doesn't seem to be the correct behavior. was: The decode method from WSSecurityUtil doesn't appear to do the right thing when sending NoSecurity. If we're sending for instance "UsernameToken NoSecurity Signature" we're getting back [1] From my point of view, it should probably return [1, 0, 2]. It seems like the person who wrote that code wanted NoSecurity to override any other security policy, in that case it should probably return just [0], but stopping at what we already parsed up to now and not including NoSecurity doesn't seem to be the correct behavior. > WSSecurityUtil.decodeAction misbehaving when sending NoSecurity > --------------------------------------------------------------- > > Key: WSS-610 > URL: https://issues.apache.org/jira/browse/WSS-610 > Project: WSS4J > Issue Type: Bug > Components: WSS4J Core > Reporter: Alexandru-Constantin Bledea > Assignee: Colm O hEigeartaigh > > The decode method from org.apache.wss4j.dom.util.WSSecurityUtil doesn't appear to do the right thing when sending NoSecurity. > If we're sending for instance "UsernameToken NoSecurity Signature" we're getting back [1] > From my point of view, it should probably return [1, 0, 2]. > However, it seems like the person who wrote that code wanted NoSecurity to override any other security policy (just like org.apache.ws.security.util.WSSecurityUtil's decodeAction), in that case it should probably return just [0], but stopping at what we already parsed up to now and not including NoSecurity doesn't seem to be the correct behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org For additional commands, e-mail: dev-help@ws.apache.org