[ https://issues.apache.org/jira/browse/AXIOM311?page=com.atlassian.jira.plugin.system.issuetabpanels:commenttabpanel&focusedCommentId=14040971#comment14040971
]
Hudson commented on AXIOM311:

FAILURE: Integrated in wsaxiomtrunk #1820 (See [https://builds.apache.org/job/wsaxiomtrunk/1820/])
AXIOM311: Eliminate the (partially redundant) CustomBuilderTest and replace it by more meaningful
test cases. (veithen: rev 1604861)
* /webservices/axiom/trunk/modules/axiomapi/src/main/java/org/apache/axiom/om/impl/builder/CustomBuilder.java
* /webservices/axiom/trunk/modules/axiomapi/src/main/java/org/apache/axiom/om/impl/builder/StAXOMBuilder.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/impl/builder/CustomBuilderTest.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/builder/TestRegisterCustomBuilderForPayload.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestCloneWithSourcedElement1.java
* /webservices/axiom/trunk/testsuites/soaptestsuite/src/main/java/org/apache/axiom/ts/soap/TestMessage.java
AXIOM311: Refactored some OMDocument tests. (veithen: rev 1604857)
* /webservices/axiom/trunk/modules/axiomapi/src/test/java/org/apache/axiom/om/OMDocumentTestBase.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/om/OMTestSuiteBuilder.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/om/builder/TestMalformedDocument.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/om/document/TestBuild.java
AXIOM311: Refactored a test case for the registerCustomBuilder method. (veithen: rev 1604855)
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/impl/builder/CustomBuilderTest.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/builder/TestRegisterCustomBuilder.java
AXIOM311: Removed some redundant/irrelevant/disabled test cases. (veithen: rev 1604854)
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/OMTest.java
AXIOM311: Replaced an old test case for the isComplete method by a more meaningful one. (veithen:
rev 1604853)
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/OMTest.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/om/OMTestSuiteBuilder.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/om/element/TestIsCompleteWithParser.java
* AXIOM311: Eliminated the old soapmessage.xml test message and replaced it with TestMessageSet.WSA.
* Addressed some cloning issues identified in the process. (veithen: rev 1604852)
* /webservices/axiom/trunk/modules/axiomapi/src/test/java/org/apache/axiom/om/TestConstants.java
* /webservices/axiom/trunk/modules/axiomapi/src/test/resources/soap/soap11/soapmessage.xml
* /webservices/axiom/trunk/modules/axiomapi/src/test/resources/soap/soap12/soapmessage.xml
* /webservices/axiom/trunk/modules/axiomimpl/src/main/java/org/apache/axiom/soap/impl/llom/soap12/SOAP12FaultValueImpl.java
* /webservices/axiom/trunk/modules/axiomimpl/src/test/java/org/apache/axiom/soap/impl/llom/SOAPImplementationTest.java
* /webservices/axiom/trunk/modules/axiomtests/pom.xml
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/OMCachingTest.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/OMTestCase.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/factory/OMLinkedListImplFactoryTest.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/impl/builder/CustomBuilderTest.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/impl/serializer/ElementSerializerTest.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/impl/serializer/OMSerializerTest.java
* /webservices/axiom/trunk/modules/axiomtests/src/test/java/org/apache/axiom/om/util/OMElementHelperTest.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/om/element/TestDiscardIncomplete.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestCase.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/TestMessageAdapter.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/body/TestCloneOMElement.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/builder/TestCommentInProlog.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/builder/TestRegisterCustomBuilderForPayloadAfterSOAPFaultCheck.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestClone.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestGetXMLStreamReaderWithoutCachingWithPartiallyBuiltHeaderBlock.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/header/TestDiscardPartiallyBuilt.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/message/TestCloneIncomplete.java
* /webservices/axiom/trunk/modules/axiomtestsuite/src/main/java/org/apache/axiom/ts/soap/message/TestGetOMFactoryWithParser.java
* /webservices/axiom/trunk/testsuites/soaptestsuite/src/main/java/org/apache/axiom/ts/soap/TestMessageSet.java
* /webservices/axiom/trunk/testsuites/soaptestsuite/src/main/resources/testmessage/set/commentinprolog.xml
AXIOM311: Eliminate unnecessary build artifacts and dependencies. (veithen: rev 1604851)
* /webservices/axiom/trunk/modules/axiomdom/pom.xml
* /webservices/axiom/trunk/modules/axiomimpl/pom.xml
* /webservices/axiom/trunk/modules/axiomtests/pom.xml
> Improve the Axiom test suite
> 
>
> Key: AXIOM311
> URL: https://issues.apache.org/jira/browse/AXIOM311
> Project: Axiom
> Issue Type: Improvement
> Reporter: Andreas Veithen
> Fix For: 1.2.16
>
>
> axiomtests contains a rich set of unit tests, but things could still be improved by
applying a common set of tests to both LLOM and DOOM. Indeed the test coverage of DOOM is
much lower than that of LLOM. I already refactored some of the tests so that they are applied
to both OM implementations, but we should push things further.
> One specific problem is that since all tests are in a common Maven module which depends
on both axiomimpl and axiomdom, it happens that some DOOM tests accidentally use the LLOM
implementation (which is the default). This could be avoided by moving the tests out of axiomtests
into the axiomapi, axiomimpl and axiomdom. Looking at the description in axiomtests/pom.xml,
It seems that this was actually the original intention:
> [quote] The Axiom test suite. This ought to be split into several parts and be made a
part of axiomapi, axiomimpl and axiomdom. However, that's not as easy as it seems. The
intention is to start with axiomtest and continuosly move parts to the actual projects. [/quote]
> It is indeed true that this is not as easy as it seems. I can see the following difficulties:
> 1) In Maven, the fact that module B depends on module A doesn't imply that the unit tests
of module B can refer to code in the unit tests of module A. If we want to avoid creating
new modules for the test code shared among several other modules, we need to get around this
problem. We had the same issue in Synapse and it can be solved by using the testjar goal
in mavenjarplugin which attaches a JAR with the unit test code. It is then sufficient to
add this as a dependency (in scope test) to the other modules.
> 2) We not only need to split the code, but also the test messages and documents in axiomtests/testresources.
As with the code, some of these documents would be used by several modules. The problem here
is that the tests don't access them as classpath resources but as files (see AbstractTestCase).
If we change that, i.e. if we load them using Class#getResourceAsStream, then the solution
for item 1 will also solves this problem. But maybe there is a particular reason why AbstractTestCase
uses file access?
> 3) Currently axiomtests overrides the JavaMail dependency of axiomapi (see WSCOMMONS417).
If we move the tests to the module to which they apply, we can no longer do this, but I think
it is a bad practice anyway.
> Does anyone see other difficulties that block us from splitting axiomtests?

This message was sent by Atlassian JIRA
(v6.2#6252)

To unsubscribe, email: devunsubscribe@ws.apache.org
For additional commands, email: devhelp@ws.apache.org
