Mailing-List: contact dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ws.apache.org
Date: Sat, 15 Sep 2012 07:52:07 +1100 (NCT)
From: "Hudson (JIRA)" <jira@apache.org>
To: dev@ws.apache.org
Message-ID: <1993483316.82274.1347655927833.JavaMail.jiratomcat@arcas>
In-Reply-To: <2048601573.42136.1342106074395.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (AXIOM-432) Updating the last child is not
 correct unless we are replacing the last child
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456127#comment-13456127 ] 

Hudson commented on AXIOM-432:
------------------------------

Integrated in ws-axiom-trunk #1214 (See [https://builds.apache.org/job/ws-axiom-trunk/1214/])
    AXIOM-432: Added more test cases and assertions for Node#replaceChild and fixed several issues. (Revision 1384874)

     Result = SUCCESS
veithen : 
Files : 
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/ReplaceChildTestCase.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirst.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirstWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildLast.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildLastWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildMiddle.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildMiddleWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildSingle.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/OMDOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildFirstIncomplete.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildIncomplete.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildMiddleIncomplete.java

                
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
>                 Key: AXIOM-432
>                 URL: https://issues.apache.org/jira/browse/AXIOM-432
>             Project: Axiom
>          Issue Type: Bug
>          Components: DOOM
>            Reporter: detelin20@yahoo.com
>            Assignee: Andreas Veithen
>             Fix For: 1.2.14
>
>         Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org