Return-Path: X-Original-To: apmail-ws-dev-archive@www.apache.org Delivered-To: apmail-ws-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BB9C9333 for ; Fri, 17 Feb 2012 02:38:25 +0000 (UTC) Received: (qmail 90959 invoked by uid 500); 17 Feb 2012 02:38:23 -0000 Delivered-To: apmail-ws-dev-archive@ws.apache.org Received: (qmail 90606 invoked by uid 500); 17 Feb 2012 02:38:23 -0000 Mailing-List: contact dev-help@ws.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ws.apache.org Delivered-To: mailing list dev@ws.apache.org Received: (qmail 90599 invoked by uid 99); 17 Feb 2012 02:38:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2012 02:38:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2012 02:38:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BE8D51BB513 for ; Fri, 17 Feb 2012 02:37:59 +0000 (UTC) Date: Fri, 17 Feb 2012 02:37:59 +0000 (UTC) From: "Freeman Fang (Updated) (JIRA)" To: dev@ws.apache.org Message-ID: <201331239.49362.1329446279781.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1670236106.49333.1329445319659.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (WSS-341) the "FIRST step" check in SignatureTrustValidator.verifyTrustInCert ignore the enableRevocation status MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated WSS-341: ----------------------------- Attachment: WSS-341.patch > the "FIRST step" check in SignatureTrustValidator.verifyTrustInCert ignore the enableRevocation status > ------------------------------------------------------------------------------------------------------ > > Key: WSS-341 > URL: https://issues.apache.org/jira/browse/WSS-341 > Project: WSS4J > Issue Type: Bug > Reporter: Freeman Fang > Assignee: Colm O hEigeartaigh > Attachments: WSS-341.patch > > > currently it's > if (isCertificateInKeyStore(crypto, cert)) { > return true; > } > However if the crypto here has keystore, then if cert is in it, it will return true in this case, so it can't reach the > crypto.verifyTrust(x509certs, enableRevocation) later to check with the revocation. This logic is wrong in case the cert is in keystore but already get revoked. > The SignatureCRLTest can't cover this case because the CA Merlin crypto it passed in only have truststore, we need check enableRevocation first before we check isCertificateInKeyStore(crypto, cert) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org For additional commands, e-mail: dev-help@ws.apache.org