Mailing-List: contact dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ws.apache.org
Date: Tue, 13 Dec 2011 14:07:30 +0000 (UTC)
From: "Maxim Naidenov (Closed) (JIRA)" <jira@apache.org>
To: dev@ws.apache.org
Message-ID: 
 <1982436517.5754.1323785250893.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2093720887.4817.1323764131030.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Closed] (WSS-330) CryptoBase.getAliasForX509CertThumb
 calculates hash wrongly, could only match first certificate correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/WSS-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maxim Naidenov closed WSS-330.
------------------------------

    Resolution: Not A Problem

Hi Colm,

you are right, seems I was too fast to write a bug report before doing a good old debug and especially carefully checking the certificates that are compared.
Sorry for taking your time.

Maxim
                
> CryptoBase.getAliasForX509CertThumb calculates hash wrongly, could only match first certificate correctly
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSS-330
>                 URL: https://issues.apache.org/jira/browse/WSS-330
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.12
>            Reporter: Maxim Naidenov
>            Assignee: Colm O hEigeartaigh
>             Fix For: 1.5.13
>
>
> The method CryptoBase.getAliasForX509CertThumb(byte[] thumb) does not calculate the hash of certificates in the keystore correctly and could possibly match only the first certificate.
> This is because the SHA1 message digest is reset once:
> sha = MessageDigest.getInstance("SHA-1");
> sha.reset();
> but is updated every time while enumerating over certificates in the keystore:
> sha.update(cert.getEncoded());
> byte[] data = sha.digest();
> The fix would be to move the digest reset in the beginning of the enumeration loop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org