Mailing-List: contact dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ws.apache.org
Date: Fri, 8 Jul 2011 20:27:16 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: dev@ws.apache.org
Message-ID: 
 <870774791.12304.1310156836656.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <986669483.62549.1302984305884.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (NEETHI-9) Errors in XML object model
 conversions are not handled properly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/NEETHI-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062157#comment-13062157 ] 

Hudson commented on NEETHI-9:
-----------------------------

Integrated in neethi-trunk #124 (See [https://builds.apache.org/job/neethi-trunk/124/])
    NEETHI-9: Make sure that Converter implementations throw an exception instead of returning null.

veithen : 
Files : 
* /webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/converters/StaxToDOMConverter.java
* /webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/converters/ConverterException.java
* /webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/converters/DOMToStaxConverter.java
* /webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/converters/Converter.java


> Errors in XML object model conversions are not handled properly
> ---------------------------------------------------------------
>
>                 Key: NEETHI-9
>                 URL: https://issues.apache.org/jira/browse/NEETHI-9
>             Project: Neethi
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Andreas Veithen
>            Priority: Minor
>
> Implementations of Converter#convert return null when an error occurs during conversion. On the other hand, AssertionBuilderFactoryImpl#invokeBuilder doesn't check for a null return value. This means that when an error occurs, a null value is passed to AssertionBuilder#build, which leads to unexpected results.
> Also, the fact that the implementations of Converter#convert swallow most exceptions makes it hard to debug issues caused by problems during object model conversion.
> We have two options:
> 1. Let Converter#convert throw an exception if there is a problem.
> 2. Add a null check in AssertionBuilderFactoryImpl#invokeBuilder (to solve the first problem) and make sure that exceptions thrown in Converter#convert are logged (to solve the second problem). In this case, we need to agree on the logging API to be used (commons logging or SLF4J).
> Personally, I prefer option 1.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org