ws-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Veithen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NEETHI-9) Errors in XML object model conversions are not handled properly
Date Wed, 06 Jul 2011 21:05:17 GMT

    [ https://issues.apache.org/jira/browse/NEETHI-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060842#comment-13060842
] 

Andreas Veithen commented on NEETHI-9:
--------------------------------------

I think that this case meets the two criteria for using an unchecked exception:
* The exception occurs only if something goes badly wrong (like a missing or incompatible
dependency lib).
* There is nothing that the calling code could to about the error, except for reporting it
to the user.

> Errors in XML object model conversions are not handled properly
> ---------------------------------------------------------------
>
>                 Key: NEETHI-9
>                 URL: https://issues.apache.org/jira/browse/NEETHI-9
>             Project: Neethi
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Andreas Veithen
>            Priority: Minor
>
> Implementations of Converter#convert return null when an error occurs during conversion.
On the other hand, AssertionBuilderFactoryImpl#invokeBuilder doesn't check for a null return
value. This means that when an error occurs, a null value is passed to AssertionBuilder#build,
which leads to unexpected results.
> Also, the fact that the implementations of Converter#convert swallow most exceptions
makes it hard to debug issues caused by problems during object model conversion.
> We have two options:
> 1. Let Converter#convert throw an exception if there is a problem.
> 2. Add a null check in AssertionBuilderFactoryImpl#invokeBuilder (to solve the first
problem) and make sure that exceptions thrown in Converter#convert are logged (to solve the
second problem). In this case, we need to agree on the logging API to be used (commons logging
or SLF4J).
> Personally, I prefer option 1.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


Mime
View raw message