[ https://issues.apache.org/jira/browse/NEETHI-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Veithen resolved NEETHI-9.
----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.1
> Errors in XML object model conversions are not handled properly
> ---------------------------------------------------------------
>
> Key: NEETHI-9
> URL: https://issues.apache.org/jira/browse/NEETHI-9
> Project: Neethi
> Issue Type: Bug
> Affects Versions: 3.0
> Reporter: Andreas Veithen
> Priority: Minor
> Fix For: 3.0.1
>
>
> Implementations of Converter#convert return null when an error occurs during conversion.
On the other hand, AssertionBuilderFactoryImpl#invokeBuilder doesn't check for a null return
value. This means that when an error occurs, a null value is passed to AssertionBuilder#build,
which leads to unexpected results.
> Also, the fact that the implementations of Converter#convert swallow most exceptions
makes it hard to debug issues caused by problems during object model conversion.
> We have two options:
> 1. Let Converter#convert throw an exception if there is a problem.
> 2. Add a null check in AssertionBuilderFactoryImpl#invokeBuilder (to solve the first
problem) and make sure that exceptions thrown in Converter#convert are logged (to solve the
second problem). In this case, we need to agree on the logging API to be used (commons logging
or SLF4J).
> Personally, I prefer option 1.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
|