ws-commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Daniels <g...@thoughtcraft.com>
Subject Re: [jira] Created: (WSCOMMONS-427) StreamingOMSerializer#serializeXOPInclude doesn't decode cid: URLs
Date Sun, 04 Jan 2009 14:28:21 GMT
Hi Andreas:

You didn't mark this as a blocker, but it sounds fairly serious.  Should
we hold 1.2.8 until this is fixed?

--Glen

Andreas Veithen (JIRA) wrote:
> StreamingOMSerializer#serializeXOPInclude doesn't decode cid: URLs
> ------------------------------------------------------------------
> 
>                  Key: WSCOMMONS-427
>                  URL: https://issues.apache.org/jira/browse/WSCOMMONS-427
>              Project: WS-Commons
>           Issue Type: Bug
>           Components: AXIOM
>             Reporter: Andreas Veithen
>             Assignee: Andreas Veithen
>             Priority: Critical
> 
> 
> StreamingOMSerializer#serializeXOPInclude contains the following code:
> 
>        String cid = reader.getAttributeValue(null, "href");
>        DataHandler dh = getDataHandler(cid, (OMAttachmentAccessor) reader);
>        if (dh == null) {
>            return false;
>        }
>        
>        OMFactory omFactory = OMAbstractFactory.getOMFactory();
>        OMText omText = omFactory.createOMText(dh, true);
>        omText.setContentID(cid);
> 
> This means that the contentId set on the OMText instance is incorrect: it is actually
not the Content-ID, but the cid: URL. This implies that the generated  XOP/MTOM message is
incorrect.
> 
> The code in serializeXOPInclude should decode the href attribute in the same way as XOPAwareStAXOMBuilder#createOMElement
(which uses ElementHelper.getContentID).
> 

Mime
View raw message