Return-Path: Delivered-To: apmail-ws-axis-cvs-archive@www.apache.org Received: (qmail 67684 invoked from network); 17 Jan 2006 21:41:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Jan 2006 21:41:15 -0000 Received: (qmail 5776 invoked by uid 500); 17 Jan 2006 21:41:14 -0000 Delivered-To: apmail-ws-axis-cvs-archive@ws.apache.org Received: (qmail 5715 invoked by uid 500); 17 Jan 2006 21:41:14 -0000 Mailing-List: contact axis-cvs-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-cvs@ws.apache.org Received: (qmail 5704 invoked by uid 99); 17 Jan 2006 21:41:13 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2006 13:41:13 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 17 Jan 2006 13:41:13 -0800 Received: (qmail 67310 invoked by uid 65534); 17 Jan 2006 21:40:52 -0000 Message-ID: <20060117214052.67308.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r369926 - /webservices/axis/trunk/java/src/org/apache/axis/configuration/FileProvider.java Date: Tue, 17 Jan 2006 21:40:52 -0000 To: axis-cvs@ws.apache.org From: dug@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dug Date: Tue Jan 17 13:40:49 2006 New Revision: 369926 URL: http://svn.apache.org/viewcvs?rev=369926&view=rev Log: When you can't find the service just return null not an exception. When the code is just looking to see if a service exists it shouldn't have to deal with the overhead of catching and creating an exception, returning null is the right way to do it. Modified: webservices/axis/trunk/java/src/org/apache/axis/configuration/FileProvider.java Modified: webservices/axis/trunk/java/src/org/apache/axis/configuration/FileProvider.java URL: http://svn.apache.org/viewcvs/webservices/axis/trunk/java/src/org/apache/axis/configuration/FileProvider.java?rev=369926&r1=369925&r2=369926&view=diff ============================================================================== --- webservices/axis/trunk/java/src/org/apache/axis/configuration/FileProvider.java (original) +++ webservices/axis/trunk/java/src/org/apache/axis/configuration/FileProvider.java Tue Jan 17 13:40:49 2006 @@ -229,10 +229,12 @@ */ public SOAPService getService(QName qname) throws ConfigurationException { SOAPService service = deployment.getService(qname); + /* Why????? Dug if (service == null) { throw new ConfigurationException(Messages.getMessage("noService10", qname.toString())); } + */ return service; }