Mailing-List: contact users-help@wicket.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@wicket.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Date: Mon, 18 Feb 2013 21:16:01 +0100
From: Carl-Eric Menzel <cmenzel@wicketbuch.de>
To: users@wicket.apache.org
Subject: Re: Migration issue: page that writes binary data to the response
Message-ID: <20130218211601.79e05bf9@privatron>
In-Reply-To: <20130218180341.GA10179@fh-wedel.de>
References: <20130218165537.GA9865@fh-wedel.de>
	<20130218182511.4afa5f36@robotron>
	<20130218180341.GA10179@fh-wedel.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 18 Feb 2013 19:03:41 +0100
Martin Dietze <di@fh-wedel.de> wrote:

> On Mon, February 18, 2013, Carl-Eric Menzel wrote:
> 
> > Is there a particular reason you're using a page?
> 
> One - unfortunately - big reason: it's legacy code (most of
> which I did not even write myself). The Wicket upgrade is badly
> needed for browser compatibiy, however I don't want to change
> code if it's not absolutely necessary. 

For generating binaries, I would *really* recommend doing this change.
Pages simply are not a good fit for that. Also, it shouldn't be that
big of a change, since you're writing to the Response anyway. Within
AbstractResource's WriteCallback you're going to use the same Response
object, so you can simply copy most of your code over without much
change.

(pseudocode from memory, but close enough)

MyResource extends AbstractResource {
 @Override newResourceResponse(Attributes att) {
  att.setFilename("foo.pdf");
  att.disableCaching();
  att.setContentType("text/pdf");
  att.setWriteCallback(new WriteCallback() {
    @Override writeData(Attributes att) {
      Response r = att.getResponse();
      // write to the response here like you did before
    }
  });
 }
}

Except in this case you won't have to mangle the Response object like
you have to do with the page.

Carl-Eric


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org