Mailing-List: contact dev-help@wicket.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@wicket.apache.org
Received-SPF: pass (athena.apache.org: domain of martijn.dashorst@gmail.com
 designates 209.85.160.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAMomwMo2he5eb1_kaLdVCitAALjBeQEpjoN+k=b6UzrfyZf14w@mail.gmail.com>
References: 
 <CAMomwMo2he5eb1_kaLdVCitAALjBeQEpjoN+k=b6UzrfyZf14w@mail.gmail.com>
From: Martijn Dashorst <martijn.dashorst@gmail.com>
Date: Tue, 31 Jan 2012 18:38:20 +0100
Message-ID: 
 <CAB63Y-ep7oXN-f_f7Oe79H9uxLavxH9S3jO-8_nf4wJ8p+ZJtQ@mail.gmail.com>
Subject: Re: Deprecate Component#onMarkupAttached() ?
To: dev@wicket.apache.org
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Jan 31, 2012 at 5:44 PM, Martin Grigorov <mgrigorov@apache.org> wrote:
> Now I think Component#onMarkupAttached() becomes obsolete.
> #onInitialize() serves the same purpose,
> Should we deprecate it in 1.5.x and remove it in 6.0 ?

AFAIK the proper way of deprecating would be to deprecate in 6.0 and
remove in 7.0, if we are going to utilize semver.

That said, 1.5 doesn't use semver, #onMarkupAttached() seems like a
method that is not often overridden in user code. In my workspace with
about 1M lines of code, 1k pages and 10k Java files there is only one
component that overrides the onMarkupAttached method:
org.apache.wicket.MarkupContainer.

So +1 to deprecate 1.5.x and remove in 6.0

Martijn

-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com