Return-Path: 
 <dev-return-12736-apmail-wicket-dev-archive=wicket.apache.org@wicket.apache.org>
Delivered-To: apmail-wicket-dev-archive@www.apache.org
Received: (qmail 30926 invoked from network); 14 Nov 2010 18:58:09 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 14 Nov 2010 18:58:09 -0000
Received: (qmail 93312 invoked by uid 500); 14 Nov 2010 18:58:40 -0000
Delivered-To: apmail-wicket-dev-archive@wicket.apache.org
Received: (qmail 93293 invoked by uid 500); 14 Nov 2010 18:58:40 -0000
Mailing-List: contact dev-help@wicket.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@wicket.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@wicket.apache.org>
List-Post: <mailto:dev@wicket.apache.org>
List-Id: <dev.wicket.apache.org>
Reply-To: dev@wicket.apache.org
Delivered-To: mailing list dev@wicket.apache.org
Received: (qmail 93285 invoked by uid 99); 14 Nov 2010 18:58:40 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Nov 2010 18:58:40 +0000
X-ASF-Spam-Status: No, hits=-1997.8 required=10.0
	tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9)
    by apache.org (qpsmtpd/0.29) with SMTP; Sun, 14 Nov 2010 18:58:37 +0000
Received: (qmail 30783 invoked by uid 99); 14 Nov 2010 18:57:44 -0000
Received: from localhost.apache.org (HELO mail-iw0-f173.google.com)
 (127.0.0.1)
  (smtp-auth username mgrigorov, mechanism plain)
  by minotaur.apache.org (qpsmtpd/0.29) with ESMTP;
 Sun, 14 Nov 2010 18:57:44 +0000
Received: by iwn36 with SMTP id 36so5987498iwn.32
        for <dev@wicket.apache.org>; Sun, 14 Nov 2010 10:58:15 -0800 (PST)
MIME-Version: 1.0
Received: by 10.42.96.197 with SMTP id k5mr3854466icn.174.1289761095109; Sun,
 14 Nov 2010 10:58:15 -0800 (PST)
Received: by 10.231.148.204 with HTTP; Sun, 14 Nov 2010 10:58:15 -0800 (PST)
In-Reply-To: <AANLkTimjdnC49G4fCTgLeymQnnSwu3K6RwQdu0KaEgmb@mail.gmail.com>
References: <AANLkTikGgaAgQqstSgZ63rqJyCyvCjU1Nikk-6ve81sd@mail.gmail.com>
	<AANLkTi=jWnhww4Q4T_vm6LknQPRD4xb359g_KGCegRWZ@mail.gmail.com>
	<AANLkTinSGszLcO2tbOc3eod+vyxFBH+Kwb8wu60bZY=u@mail.gmail.com>
	<AANLkTimjdnC49G4fCTgLeymQnnSwu3K6RwQdu0KaEgmb@mail.gmail.com>
Date: Sun, 14 Nov 2010 19:58:15 +0100
Message-ID: <AANLkTi=a_fQ1kJgGNcyttEd==GD0rRjrHomfiFsiVrX3@mail.gmail.com>
Subject: Re: IConverter generics
From: Martin Grigorov <mgrigorov@apache.org>
To: dev@wicket.apache.org
Content-Type: multipart/alternative; boundary=20cf303639e1eb4b9e049507e795
X-Virus-Checked: Checked by ClamAV on apache.org

--20cf303639e1eb4b9e049507e795
Content-Type: text/plain; charset=UTF-8

Improved and committed.

On Sun, Nov 14, 2010 at 5:25 PM, Igor Vaynberg <igor.vaynberg@gmail.com>wrote:

> +                               IConverter<Object> converter =
> (IConverter<Object>)getConverter(displayClass);
>
> yuck, but oh well, we will have to live with it.
>
> -                                       return new IConverter()
> +                                       return (IConverter<C>)new
> IConverter<URL>()
>
> since you are already in there, can you add a test for
> clazz,isassignableromurl() and only return the converter then? there
> are a couple of places in the patch blindly return a converter
> ignoring the class, its wrong.
>
> thanks,
>
> -igor
>
> On Sun, Nov 14, 2010 at 3:41 AM, Martin Grigorov <mgrigorov@apache.org>
> wrote:
> >
> https://issues.apache.org/jira/secure/attachment/12459553/WICKET-1568.patch
> >
> > Please review.
> >
> > On Sat, Nov 13, 2010 at 9:37 PM, Igor Vaynberg <igor.vaynberg@gmail.com
> >wrote:
> >
> >> it didnt apply as cleanly as we liked
> >>
> >> if we dont tie it to the type of the component it might work:
> >>
> >>        public <C> IConverter<C> getConverter(Class<C> type)
> >>
> >> give that a try and see if you find any weird areas.
> >>
> >> -igor
> >>
> >> On Sat, Nov 13, 2010 at 12:22 PM, Martin Grigorov <mgrigorov@apache.org
> >
> >> wrote:
> >> > Hi,
> >> >
> >> > I noticed that IConverter doesn't use generics..
> >> > Quick search showed https://issues.apache.org/jira/browse/WICKET-1568
> >> > Peter provided a patch and Johan closed it as "Fixed".
> >> > The ticket itself has no commits and IConverter and impls. don't use
> >> > generics in 1.4 and 1.5
> >> >
> >> > What's the reason ?
> >> >
> >> > martin-g
> >> >
> >>
> >
>

--20cf303639e1eb4b9e049507e795--