wicket-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Makundi <martin.maku...@koodaripalvelut.com>
Subject Re: Welcome Martin Grigorov as a core team member
Date Tue, 09 Nov 2010 10:23:13 GMT
Thanx, we will do that and attach tests. Let us know then if something
is missing.

**
Martin

2010/11/9 Martin Grigorov <mgrigorov@apache.org>:
> Javascript changes are the most problematic ones ...
> It is easy to do it for latest versions of Firefox, IE8 and Chrome, but then
> people come with IE6/7 or Safari and start filing tickets ...
>
> If you can create Selenium/WebDriver/... tests for wicket-examples > ajax >
> modal window this will be the best.
> You can even extend the example to use nested iframe for this ticket.
>
> On Tue, Nov 9, 2010 at 11:01 AM, Martin Makundi <
> martin.makundi@koodaripalvelut.com> wrote:
>
>> > Don't hesitate to attach quickstart app or tests to any of the tickets.
>> > This is one of the reasons the Wicket team invited me to join them :-)
>>
>> The problem is that this is a drop-in replacement/fix for modal
>> window, it should pass all existing modal window tests. So there isn't
>> really any new wicket-level functionality to test. All changes are in
>> javascript. Is it possible to drop in selenium tests?
>>
>> **
>> Martin
>>
>> >
>> > On Tue, Nov 9, 2010 at 10:44 AM, Martin Makundi <
>> > martin.makundi@koodaripalvelut.com> wrote:
>> >
>> >> Ok. We are currently testing it and if you have any test code snipplet
>> >> requests, please just comment on the ticket and we will provide what
>> >> you need whereas wickettester/junit are concerned.
>> >>
>> >> **
>> >> Martin
>> >>
>> >> 2010/11/9 Martin Grigorov <mgrigorov@apache.org>:
>> >> > Hi Martin,
>> >> >
>> >> > I am aware of the ticket.
>> >> > Last two weeks there are several tickets/discussions about
>> ModalWindow.
>> >> The
>> >> > problem is that it is used by many people and we have to be careful
>> with
>> >> the
>> >> > fixes there.
>> >> > I also saw your comment on WICKET-2053, so we will take a look at it
>> as
>> >> well
>> >> > when we star looking at it.
>> >> >
>> >> > On Tue, Nov 9, 2010 at 8:07 AM, Martin Makundi <
>> >> > martin.makundi@koodaripalvelut.com> wrote:
>> >> >
>> >> >> Hi Martin!
>> >> >>
>> >> >> Pls take a look at a fix for ModalWindows that are nested inside
>> IFrame:
>> >> >>
>> >> >> https://issues.apache.org/jira/browse/WICKET-3151
>> >> >>
>> >> >> This wasn't supported before but Rodolfo kindly added support for
it
>> >> >> and fixed some bugs in it.
>> >> >>
>> >> >> **
>> >> >> Martin
>> >> >>
>> >> >>
>> >> >> > Tue, 20 Jul 2010 08:54:07 -0700 Martin Grigorov
>> >> >> >
>> >> >> > Just feed me with patches for 1.4 ;-)
>> >> >> >
>> >> >> > 2010/7/20 Johan Compagner <jcompag...@gmail.com>
>> >> >> >
>> >> >> > > welcome!
>> >> >> > >
>> >> >> > > hope you happily merge even more stuff ;)
>> >> >> > >
>> >> >> > > johan
>> >> >>
>> >> >
>> >>
>> >
>>
>

Mime
View raw message