wicket-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Grigorov <mgrigo...@apache.org>
Subject Re: [jira] Resolved: (WICKET-3161) Can not create cookies
Date Tue, 16 Nov 2010 08:07:03 GMT
On Tue, Nov 16, 2010 at 3:10 AM, Jeremy Thomerson <jrthomerson@apache.org>wrote:

>
>
> On Sat, Nov 13, 2010 at 7:18 AM, Peter Ertl (JIRA) <jira@apache.org>wrote:
>
>>
>>     [
>> https://issues.apache.org/jira/browse/WICKET-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Peter Ertl resolved WICKET-3161.
>> --------------------------------
>>
>>       Resolution: Fixed
>>    Fix Version/s: 1.5-M4
>>
>> I am confident that this issue is fixed but I am not very happy about the
>> solution. Please feel free to improve it or send me feedback.
>>
>> I also added a test case in wicket source to test for existance of cookies
>> that were set during a link listener event.
>>
>> General question to wicket devs: Is it ok to "resolve issue" if I am not
>> happy with a solution but the issue is fixed?
>
>
> I don't see why not, although if you're really dissatisfied with the
> solution, you may want to open a follow-up ticket to clean up the solution.
>
>
> Jeremy
>
>>
>
> My approach in such cases is to attach a patch and ask for review.

martin-g

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message