wicket-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matej Knopp <matej.kn...@gmail.com>
Subject Re: [wicket 1.5] removing page version manager
Date Fri, 02 Oct 2009 21:08:13 GMT
ipageversionmanager in 1.4 is fundamentally broken because it can only
do undo and has no redo. Plus it's pain to implement for all possible
changes so noone is really bothered to do it. the concept never worked
that's why we have snapshots in diskpagestore.

for 1.5 we should have two page stores.
DiskPageStore like one
and HttpSessionStore like one that would be non-versioned. If you
really need the raw performance of HttpSessionStore you need to give
up versioning.

Alternative of making snapshots and storing them in httpsessionstore
is no good. The main bottleneck in DiskPageStore is not writing to
disk, it's serialization. So you would lose the main benefit of
httpsessionstore (speed) and you would also lose the main benefit of
diskpagestore - free heap.

-Matej

On Fri, Oct 2, 2009 at 11:03 PM, Igor Vaynberg <igor.vaynberg@gmail.com> wrote:
> can we yank ipageversionmanager and ichange out of 1.5? it has always
> been broken because no one implements ichange objects to keep the page
> state consistent.
>
> the downside is that if someone is using httpsessionstore they will
> take a bigger hit on session usage because every version is serialized
> in its entirety. the up side is that it will actually work and the
> code can be vastly simplified.
>
> any concerns?
>
> -igor
>

Mime
View raw message