Return-Path: Delivered-To: apmail-incubator-wicket-dev-archive@locus.apache.org Received: (qmail 26759 invoked from network); 8 Feb 2007 09:44:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Feb 2007 09:44:55 -0000 Received: (qmail 33488 invoked by uid 500); 8 Feb 2007 09:45:02 -0000 Delivered-To: apmail-incubator-wicket-dev-archive@incubator.apache.org Received: (qmail 33466 invoked by uid 500); 8 Feb 2007 09:45:02 -0000 Mailing-List: contact wicket-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: wicket-dev@incubator.apache.org Delivered-To: mailing list wicket-dev@incubator.apache.org Received: (qmail 33457 invoked by uid 99); 8 Feb 2007 09:45:02 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2007 01:45:02 -0800 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of jcompagner@gmail.com designates 64.233.162.224 as permitted sender) Received: from [64.233.162.224] (HELO nz-out-0506.google.com) (64.233.162.224) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2007 01:44:52 -0800 Received: by nz-out-0506.google.com with SMTP id j2so447018nzf for ; Thu, 08 Feb 2007 01:44:31 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=po+ha3tkp3cLb6e2aG/b6YcIx4ynhGVUWk/G4EOlrynVbQxbrVHZvBcFM88xiyezxDNmA0Bya1/W0dWS8BsSxWelqduekCrC8eAYntY6TEsPD33yIWvbKKNHzpBUNT8t4mkml1CAihFHs24M1425vm3bEaBbpc7V+pMNrnF1JQQ= Received: by 10.114.12.9 with SMTP id 9mr3608022wal.1170927871489; Thu, 08 Feb 2007 01:44:31 -0800 (PST) Received: by 10.114.133.9 with HTTP; Thu, 8 Feb 2007 01:44:31 -0800 (PST) Message-ID: <2e1ce7cd0702080144k19de4beak57278fb5aad7b8dc@mail.gmail.com> Date: Thu, 8 Feb 2007 10:44:31 +0100 From: "Johan Compagner" To: wicket-dev@incubator.apache.org Subject: Re: maxPageVersions In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_6525_17272023.1170927871079" References: X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_6525_17272023.1170927871079 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline no it is not if you use the normal HttpSessionStore Then you use the AccessStackPageMap and that uses the Evict Strategy for (default 7) page and page versions. So with the normal HttpSessionStore there will always be 7 unique pages or 7 page versions of one page or a combination. johan On 2/8/07, Eelco Hillenius wrote: > > See also http://issues.apache.org/jira/browse/WICKET-266 > > Eelco > > On 2/7/07, Eelco Hillenius wrote: > > Hi, > > > > Thanks for the fix for the FilePageStore version manager Johan. Now, > > there still is the UndoPageVersionManager that is used when you > > configure the HttpSessionStore. The number is now max-int, which is > > crazy and dangerous. I think a better max would be, say, 30. > > > > WDYT? > > > > Btw, I think we should apply this on 1.2.x as well or if that is too > > late with the release half done, put up a warning somewhere. > > > > Eelco > > > ------=_Part_6525_17272023.1170927871079--