Return-Path: Delivered-To: apmail-incubator-wicket-dev-archive@locus.apache.org Received: (qmail 76779 invoked from network); 3 Feb 2007 22:38:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Feb 2007 22:38:57 -0000 Received: (qmail 67764 invoked by uid 500); 3 Feb 2007 22:39:03 -0000 Delivered-To: apmail-incubator-wicket-dev-archive@incubator.apache.org Received: (qmail 67647 invoked by uid 500); 3 Feb 2007 22:39:03 -0000 Mailing-List: contact wicket-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: wicket-dev@incubator.apache.org Delivered-To: mailing list wicket-dev@incubator.apache.org Received: (qmail 67638 invoked by uid 99); 3 Feb 2007 22:39:03 -0000 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of jcompagner@gmail.com designates 64.233.162.234 as permitted sender) Received: from [64.233.162.234] (HELO nz-out-0506.google.com) (64.233.162.234) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Feb 2007 14:39:00 -0800 Received: by nz-out-0506.google.com with SMTP id j2so1054115nzf for ; Sat, 03 Feb 2007 14:37:33 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=BARq5Nb5ycS+WVYMWKsSHxPKG3gzJnJBAaUqYM2obwjUR8kc4buteNkwLHj/HWxn3poxFdv6NGfMwvrTHIazHXg3Q1FyLbgFV56gKtfTzCF60CrrErcexpWkTIO1AB6icQHM1fCExgCW3sT2V+SGzUv/MNF1iLwFXXE23B4GYlw= Received: by 10.114.181.1 with SMTP id d1mr487911waf.1170542252778; Sat, 03 Feb 2007 14:37:32 -0800 (PST) Received: by 10.114.130.12 with HTTP; Sat, 3 Feb 2007 14:37:32 -0800 (PST) Message-ID: <2e1ce7cd0702031437u1e1225beq5b77b64bec6effc4@mail.gmail.com> Date: Sat, 3 Feb 2007 23:37:32 +0100 From: "Johan Compagner" To: wicket-dev@incubator.apache.org Subject: Re: About WicketFilter refactoring In-Reply-To: <23eb48360702031320g5283ec53mfead555578094751@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_10370_22194727.1170542252742" References: <20070130213812.GB60719@zoupla.cottages> <23eb48360702031320g5283ec53mfead555578094751@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_10370_22194727.1170542252742 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline just use string.indexOf() ;) johan On 2/3/07, Igor Vaynberg wrote: > > we already have a pull parser in wicket, why arent we using that? > > -igor > > > On 2/3/07, Eelco Hillenius wrote: > > > > > Therefore I suggest to compute the filter path in a static block, > > > as web.xml is not supposed to change during the lifetime of the > > > app, nor between initialization of the various WicketFilters. > > > > Usually, using static backfires in some way or the other. > > > > I think wicket-example's startup time is still reasonable, though a > > lot slower for sure. An optimization could be to use SAX parsing > > rather then DOM. With a static block, I would be afraid to introduce > > classloader problems for some setups (even if it is against the spec > > etc); this way of parsing the web.xml pretty much guarantees that will > > never happen. > > > > My 2c, > > > > Eelco > > > ------=_Part_10370_22194727.1170542252742--