Mailing-List: contact commits-help@wicket.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@wicket.apache.org
Date: Tue, 4 Jul 2017 18:19:00 +0000 (UTC)
From: "Kamil (JIRA)" <jira@apache.org>
To: commits@wicket.apache.org
Message-ID: <JIRA.13083910.1498852639000.168574.1499192340056@Atlassian.JIRA>
In-Reply-To: <JIRA.13083910.1498852639000@Atlassian.JIRA>
References: <JIRA.13083910.1498852639000@Atlassian.JIRA> <JIRA.13083910.1498852639070@jira-lw-us.apache.org>
Subject: [jira] [Commented] (WICKET-6412) Model#orElse behavior is
 inconsistent!
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 04 Jul 2017 18:19:04 -0000


    [ https://issues.apache.org/jira/browse/WICKET-6412?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D160=
73986#comment-16073986 ]=20

Kamil commented on WICKET-6412:
-------------------------------

I think, that the misunderstanding here is that you think about using Model=
s in Wicket "internals" ("it defines methods to be called by components", "=
make it easier to chain models") while we want to USE models in our applica=
tion.
For example:
{code}
@Override
protected void onConfigure() {
=09super.onConfigure();
=09if(isNull(model.getObject())){
=09=09setResponsePage(NotFoundPage.class);
=09}
}
{code}

> Model#orElse behavior is inconsistent!
> --------------------------------------
>
>                 Key: WICKET-6412
>                 URL: https://issues.apache.org/jira/browse/WICKET-6412
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M6
>            Reporter: Jaros=C5=82aw
>            Assignee: Sven Meier
>
> Dear Wicket Devs,
> I was very confused by Model#orElse method.
> Model and Optional have similar methods and these methods behave the same=
:
> {code}
> Optional<Integer> _optional =3D Optional.ofNullable("1").map(Integer::par=
seInt);
> IModel<Integer> _model =3D Model.of("1").map(Integer::parseInt);
> {code}
> Unfortunately "orElse" behavior is totally confusing!
> {code}
> Integer integer =3D _optional.orElse(0);
> IModel<Integer> integerIModel =3D _model.orElse(0); //WRONG!
> {code}
> It should return a Model's Object instead of Model itself!
> This definitely break the least surprise rule, so can you please change t=
hat before Wicket8 final release?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)