wicket-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sven Meier (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WICKET-6412) Model#orElse behavior is inconsistent!
Date Tue, 04 Jul 2017 19:26:02 GMT

    [ https://issues.apache.org/jira/browse/WICKET-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074018#comment-16074018
] 

Sven Meier commented on WICKET-6412:
------------------------------------

Yes, I see the point from your perspective. Your code can use IModel as every other component
does, e.g. call #getObject() on it.

You example is not convincing though: are you proposing to add another method #isNull()?

> Model#orElse behavior is inconsistent!
> --------------------------------------
>
>                 Key: WICKET-6412
>                 URL: https://issues.apache.org/jira/browse/WICKET-6412
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M6
>            Reporter: Jarosław
>            Assignee: Sven Meier
>
> Dear Wicket Devs,
> I was very confused by Model#orElse method.
> Model and Optional have similar methods and these methods behave the same:
> {code}
> Optional<Integer> _optional = Optional.ofNullable("1").map(Integer::parseInt);
> IModel<Integer> _model = Model.of("1").map(Integer::parseInt);
> {code}
> Unfortunately "orElse" behavior is totally confusing!
> {code}
> Integer integer = _optional.orElse(0);
> IModel<Integer> integerIModel = _model.orElse(0); //WRONG!
> {code}
> It should return a Model's Object instead of Model itself!
> This definitely break the least surprise rule, so can you please change that before Wicket8
final release?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message